App::Link: the big merge

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

App::Link: the big merge

Post by realthunder »

PR link: https://github.com/FreeCAD/FreeCAD/pull/2350

I have documented the changes through comments in each individual commits, with links to my wiki for more details. For an overview of the Link design, see here, and most of the core changes, here.

PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: App::Link: the big merge

Post by Jee-Bee »

Good luck with the merge!! i hope is will added to master soon!! 8-)
eugebcn
Posts: 1
Joined: Tue Jul 16, 2019 7:44 pm

Re: App::Link: the big merge

Post by eugebcn »

This can be a game changer for freecad.
Good luck and thanks for your work.
User avatar
bernd
Veteran
Posts: 12851
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: App::Link: the big merge

Post by bernd »

realthunder wrote: Tue Jul 16, 2019 4:53 am PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.
on PR with lots of mixed time stamps I rewrite the time stamps ...

https://forum.freecadweb.org/viewtopic.php?f=10&t=36682
user1234
Veteran
Posts: 3478
Joined: Mon Jul 11, 2016 5:08 pm

Re: App::Link: the big merge

Post by user1234 »

Hello!

fyi: the PR does not compile on Travis CI.

Greetings
user1234
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: App::Link: the big merge

Post by ickby »

oh man, I did not compile freecad for so long that I'm not able to do it anymore :lol: it will take some time till I can poke around with it, but I will definitely have a look!

it is a impressive amount of work and documentation, looking forward to see how it works!
User avatar
kkremitzki
Veteran
Posts: 2515
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: App::Link: the big merge

Post by kkremitzki »

I'm looking forward to testing and reviewing this! Glad to see we're finally here.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
chrisb
Veteran
Posts: 54168
Joined: Tue Mar 17, 2015 9:14 am

Re: App::Link: the big merge

Post by chrisb »

kkremitzki wrote: Wed Jul 17, 2019 3:30 pm Glad to see we're finally here.
You named it!
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
fosselius
Posts: 381
Joined: Sat Apr 23, 2016 10:03 am
Contact:

Re: App::Link: the big merge

Post by fosselius »

hmm, most of the thread was removed?
Rene
Posts: 35
Joined: Sun Mar 08, 2015 6:32 pm

Re: App::Link: the big merge

Post by Rene »

fosselius wrote: Sun Aug 18, 2019 5:06 am hmm, most of the thread was removed?
In the Open subforum, thread title: App::Link: the big merge
stuff
Post Reply