BCF Support GSoC Proposal

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
yorik
Site Admin
Posts: 11458
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: BCF Support GSoC Proposal

Postby yorik » Mon Aug 19, 2019 3:17 pm

It might be a problem specific to my theme here... Let me play with it until I find out.

Your BCF plugin is now in the addons manager BTW! We can open the champagne
User avatar
Kunda1
Posts: 5226
Joined: Thu Jan 05, 2017 9:03 pm

Re: BCF Support GSoC Proposal

Postby Kunda1 » Mon Aug 19, 2019 3:19 pm

Does it show up in the Macros or Workbenches portion? If workbenches, then we need a logo
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
pPodest
Posts: 71
Joined: Sat Feb 16, 2019 3:18 pm

Re: BCF Support GSoC Proposal

Postby pPodest » Mon Aug 19, 2019 4:22 pm

yorik wrote:
Mon Aug 19, 2019 3:17 pm
It might be a problem specific to my theme here... Let me play with it until I find out.
Tomorrow I will read more into the colour stuff of Qt. Maybe I did something wrong.
yorik wrote:
Mon Aug 19, 2019 3:17 pm
Your BCF plugin is now in the addons manager BTW! We can open the champagne
Sweet, thank you! :D
champagne.gif
champagne.gif (885.77 KiB) Viewed 335 times
User avatar
pPodest
Posts: 71
Joined: Sat Feb 16, 2019 3:18 pm

Re: BCF Support GSoC Proposal

Postby pPodest » Tue Aug 20, 2019 6:15 am

Since we still needed a logo, I looked a bit on the internet, but didn't find anything where I could say for sure that we would be allowed to use it. That's why I created two versions of the logo with an online tool. It does not resemble the original logo really much, but I think it fits nonetheless.

The first version:
logo1.svg
(6.13 KiB) Downloaded 21 times
The second version:
logo2.svg
(6.75 KiB) Downloaded 14 times
So what do you think looks better?
User avatar
yorik
Site Admin
Posts: 11458
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: BCF Support GSoC Proposal

Postby yorik » Tue Aug 20, 2019 1:45 pm

I vote for 1
User avatar
pPodest
Posts: 71
Joined: Sat Feb 16, 2019 3:18 pm

Re: BCF Support GSoC Proposal

Postby pPodest » Tue Aug 20, 2019 3:11 pm

Ok thanks! I will wait still 24h for other opinions and then just take the majority vote.

My vote goes also to 1, btw.
User avatar
Kunda1
Posts: 5226
Joined: Thu Jan 05, 2017 9:03 pm

Re: BCF Support GSoC Proposal

Postby Kunda1 » Tue Aug 20, 2019 5:21 pm

1
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
chrisb
Posts: 17593
Joined: Tue Mar 17, 2015 9:14 am

Re: BCF Support GSoC Proposal

Postby chrisb » Wed Aug 21, 2019 5:09 am

1 = +1
User avatar
pPodest
Posts: 71
Joined: Sat Feb 16, 2019 3:18 pm

Re: BCF Support GSoC Proposal

Postby pPodest » Wed Aug 21, 2019 3:28 pm

Ok then, due to the few votes for option 2, the first icon will be selected!

One little question regarding the icons: I looked briefly at the code of the addon manager on the current master branch and it looks to me like the icons being added to the source repo inside the Resources directory of the addon manager, following the naming convention AddonRepoName_workbench_icon.svg.
Does the addon manager not retrieve the icons from the global variable __icon__ FCMacro file, if one is present? Because I thought it does after reading the guidlines for macros on FreeCAD-macros.

Anyways I pushed the icon now in this commit in a separate icons directory.
User avatar
yorik
Site Admin
Posts: 11458
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: BCF Support GSoC Proposal

Postby yorik » Thu Aug 22, 2019 3:29 pm

The icon that is looked for by the addon manager is ADDONNAME_workbench_icon.svg where ADDONNAME is the addon name as it appears in the Addon manager and on https://github.com/FreeCAD/FreeCAD-addons in your case BCFPlugin

The __icon__ macro field, I'm actually not sure where or even if it is used...