is in 0.18 branch already ... https://github.com/FreeCAD/FreeCAD/commit/1e9f9faSyres wrote: ↑Sun Aug 25, 2019 8:12 am Not sure if 0.18.4 is being considered but if so, this maybe relevant https://forum.freecadweb.org/viewtopic. ... 20#p329120
EDIT: The commit is https://github.com/FreeCAD/FreeCAD/commit/6a8f6e2a
Back port commits to 0.18 branch
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Back port commits to 0.18 branch
Re: Back port commits to 0.18 branch
Aesthetic Proposal - Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)
Similiar to what we did for 0.19 in git commit ba6a6d63ee9c984
I think this proposal is merited since once we consider the final version 0.18 we leave it that way for posterity. This fix makes it so that when people create youtube videos or screencasts that said multimedia can show how the StartWB was intended to be shown (with all the example files displaying their legit screenshots). See the thread to show the difference in the UI.
Edit: further justification:
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian, 0.18.x will be around for a while and people will produce videos and content and I think it makes sense from a aesthetic and Public Relations point of view to tweek this.
Similiar to what we did for 0.19 in git commit ba6a6d63ee9c984
I think this proposal is merited since once we consider the final version 0.18 we leave it that way for posterity. This fix makes it so that when people create youtube videos or screencasts that said multimedia can show how the StartWB was intended to be shown (with all the example files displaying their legit screenshots). See the thread to show the difference in the UI.
Edit: further justification:
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian, 0.18.x will be around for a while and people will produce videos and content and I think it makes sense from a aesthetic and Public Relations point of view to tweek this.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
- kkremitzki
- Veteran
- Posts: 2515
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: Back port commits to 0.18 branch
+1, IMO it is more of a bug fix than an added feature so it seems OK to backport.
Re: Back port commits to 0.18 branch
Adding the thumbnail is adding a new feature. The code still works just fine, if the thumbnail isn't there.
P.S. Therefore sorry, this isn't about fixing any bug. Said that, i don't really care whatever happens next, and don't plan to invest any more time in it.
P.S. Therefore sorry, this isn't about fixing any bug. Said that, i don't really care whatever happens next, and don't plan to invest any more time in it.
Re: Back port commits to 0.18 branch
I don't know how complicated backports are, but I'm in general against backporting minor issues. The benefit is low and there is always some danger that another issue is introduced - perhaps an even more serious one.
Perhaps we should discuss this from a more general view. My opinion: backports for crash, destroyed models, complicated workaround needed. No backports for cosmetic changes.
We usually have a very stable developer version which very well can be recommended for daily work. The Big Link Merge makes the situation currently different, but I'm confident, that this will settle soon.
Perhaps we should discuss this from a more general view. My opinion: backports for crash, destroyed models, complicated workaround needed. No backports for cosmetic changes.
We usually have a very stable developer version which very well can be recommended for daily work. The Big Link Merge makes the situation currently different, but I'm confident, that this will settle soon.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: Back port commits to 0.18 branch
Case in point: see how long older version of FC are still aroundKunda1 wrote: ↑Tue Sep 03, 2019 9:03 pm Edit: further justification:
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian, 0.18.x will be around for a while and people will produce videos and content and I think it makes sense from a aesthetic and Public Relations point of view to tweek this.
I also agree with @kkremitzki that this is more a bugfix than a feature since this should of been working but it wasn't. It's a regression actually.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Re: Back port commits to 0.18 branch
Yeah, and lets add App::Link too.
Re: Back port commits to 0.18 branch
After review and hopefully merge happens:
https://github.com/FreeCAD/FreeCAD/pull/2520
And once the proposed change will get included in FreeCAD 0.19 AppImage. I will test if everything works as expected. If yes, this PR should be back ported and to be included in FreeCAD 0.18.4 (AppImage).
https://github.com/FreeCAD/FreeCAD/pull/2520
And once the proposed change will get included in FreeCAD 0.19 AppImage. I will test if everything works as expected. If yes, this PR should be back ported and to be included in FreeCAD 0.18.4 (AppImage).
- wandererfan
- Veteran
- Posts: 6317
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: Back port commits to 0.18 branch
This fix https://github.com/FreeCAD/FreeCAD/pull/2624 makes a dramatic difference in TD response time for some models (such as this one: https://www.forum.freecadweb.org/viewto ... =3&t=40064).
If we do a v0.18.4, I'd like to include this fix. Should I merge it now?
If we do a v0.18.4, I'd like to include this fix. Should I merge it now?
Re: Back port commits to 0.18 branch
Yes. There are a few more fixes coming soon.If we do a v0.18.4, I'd like to include this fix. Should I merge it now?