SlopedPlanesMacro

Show off your FreeCAD projects here!
User avatar
Kunda1
Posts: 8687
Joined: Thu Jan 05, 2017 9:03 pm

Re: SlopedPlanesMacro

Postby Kunda1 » Sun Sep 15, 2019 8:22 pm

galou_breizh wrote:
Sun Sep 15, 2019 7:14 pm
I think that the reason why the SlopedPlanes macro was added through https://github.com/FreeCAD/FreeCAD-addons rather than https://github.com/FreeCAD/FreeCAD-macros was that the Addon-Manager had no support for macros over multiple files. This has been solved in the mean time, so that this macro could be moved to the official macro repository.
Nice. Once we've moved it then I'll remove it from the FreeCAD-addons
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 8687
Joined: Thu Jan 05, 2017 9:03 pm

Re: SlopedPlanesMacro

Postby Kunda1 » Wed Oct 09, 2019 4:34 pm

Kunda1 wrote:
Sun Sep 15, 2019 8:22 pm
galou_breizh wrote:
Sun Sep 15, 2019 7:14 pm
I think that the reason why the SlopedPlanes macro was added through https://github.com/FreeCAD/FreeCAD-addons rather than https://github.com/FreeCAD/FreeCAD-macros was that the Addon-Manager had no support for macros over multiple files. This has been solved in the mean time, so that this macro could be moved to the official macro repository.
Nice. Once we've moved it then I'll remove it from the FreeCAD-addons
Is this in a ticket somewhere ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 8687
Joined: Thu Jan 05, 2017 9:03 pm

Re: SlopedPlanesMacro

Postby Kunda1 » Sun Mar 01, 2020 12:17 am

Note: I've rebased the slopedpanes repo from the gitlab repo
But I don't think I did it right since furti's commit is at the top of the commit list
https://github.com/luzpaz/SlopedPlanesM ... its/master
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
ebrahim raeyat
Posts: 354
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: SlopedPlanesMacro

Postby ebrahim raeyat » Sun Nov 08, 2020 7:51 am

Kunda1 wrote:
Sun Mar 01, 2020 12:17 am
Note: I've rebased the slopedpanes repo from the gitlab repo
But I don't think I did it right since furti's commit is at the top of the commit list
https://github.com/luzpaz/SlopedPlanesM ... its/master
Hi Kunda1, I clone the repo, draw a sketch and run the macro, but it seems it has indentation error!!

Code: Select all

11:05:08  /home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanesPyFace.py:610: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ss is not 2:
11:05:08  /home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanesPyFace.py:771: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  elif ss is not 2:
11:05:08  Traceback (most recent call last):
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanes.FCMacro", line 34, in <module>
    import SlopedPlanes
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanes.py", line 30, in <module>
    from SlopedPlanesPyFace import _PyFace
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanesPyFace.py", line 30, in <module>
    from SlopedPlanesPyAlignment import _PyAlignment
<class 'IndentationError'>: unexpected indent (SlopedPlanesPyAlignment.py, line 1870)
11:08:48  Traceback (most recent call last):
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanes.FCMacro", line 34, in <module>
    import SlopedPlanes
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanes.py", line 30, in <module>
    from SlopedPlanesPyFace import _PyFace
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanesPyFace.py", line 30, in <module>
    from SlopedPlanesPyAlignment import _PyAlignment
<class 'IndentationError'>: unexpected indent (SlopedPlanesPyAlignment.py, line 1870)
11:09:08  Traceback (most recent call last):
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanes.py", line 30, in <module>
    from SlopedPlanesPyFace import _PyFace
  File "/home/ebi/.FreeCAD/Mod/SlopedPlanesMacro/SlopedPlanesPyFace.py", line 30, in <module>
    from SlopedPlanesPyAlignment import _PyAlignment
<class 'IndentationError'>: unexpected indent (SlopedPlanesPyAlignment.py, line 1870)
BTW, why repo did not have issue key?

Thanks.
User avatar
Kunda1
Posts: 8687
Joined: Thu Jan 05, 2017 9:03 pm

Re: SlopedPlanesMacro

Postby Kunda1 » Sun Nov 08, 2020 9:49 am

Can you reproduce by pulling from gitlab ?
https://gitlab.com/damianCaceres/slopedplanes
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
ebrahim raeyat
Posts: 354
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: SlopedPlanesMacro

Postby ebrahim raeyat » Mon Nov 09, 2020 4:30 am

Kunda1 wrote:
Sun Nov 08, 2020 9:49 am
Can you reproduce by pulling from gitlab ?
https://gitlab.com/damianCaceres/slopedplanes
Thanks, Yes, it works. Either in develop or master branche.
User avatar
Kunda1
Posts: 8687
Joined: Thu Jan 05, 2017 9:03 pm

Re: SlopedPlanesMacro

Postby Kunda1 » Mon Nov 09, 2020 10:14 am

ebrahim raeyat wrote:
Mon Nov 09, 2020 4:30 am
Kunda1 wrote:
Sun Nov 08, 2020 9:49 am
Can you reproduce by pulling from gitlab ?
https://gitlab.com/damianCaceres/slopedplanes
Thanks, Yes, it works. Either in develop or master branche.
<confused> so the error is still present?
If so, you can open an issue on gitlab and let the author know
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
ebrahim raeyat
Posts: 354
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: SlopedPlanesMacro

Postby ebrahim raeyat » Mon Nov 09, 2020 11:57 am

Kunda1 wrote:
Mon Nov 09, 2020 10:14 am
ebrahim raeyat wrote:
Mon Nov 09, 2020 4:30 am
Kunda1 wrote:
Sun Nov 08, 2020 9:49 am
Can you reproduce by pulling from gitlab ?
https://gitlab.com/damianCaceres/slopedplanes
Thanks, Yes, it works. Either in develop or master branche.
<confused> so the error is still present?
If so, you can open an issue on gitlab and let the author know
Ah, No, I can't reproduce the error :D