Align working plane to face fails in git build

[sanderboer]

Hi,

I built today's git tree and this happens when I want to align the working plane to a face :

Code: Select all

Running the Python command 'Draft_SelectPlane' failed:
Traceback (most recent call last):
  File "/opt/freecad-190908/Mod/Draft/DraftSelectPlane.py", line 78, in Activated
    if self.handle():
  File "/opt/freecad-190908/Mod/Draft/DraftSelectPlane.py", line 242, in handle
    FreeCAD.DraftWorkingPlane.alignToFace(sel.SubObjects[0], self.taskd.form.fieldOffset.Value)

'Draft_SelectPlane' object has no attribute 'taskd'

self.handle() is called before self.taskd is declared in Activated()

[vocx]

Hi,

self.handle() is called before self.taskd is declared in Activated()

This definitely seems like a bug. Recently Yorik moved the Draft SelectPlane code outside the DraftTools.py file, and into its own file. He also placed the graphical interface in a TaskSelectPlane.ui file, instead of hard coding this in DraftGui.py. Maybe he missed a few things.

Give it a few days for him to fix it.

[bernd]

https://github.com/FreeCAD/FreeCAD/comm ... ctPlane.py

[sanderboer]

I figured it out,
Cmake does not copy the Resources dir in /src/Mod/Draft/Resources over to the installed directory.
If you do it by hand, the align to face works.

[sanderboer]

Of course I thought wrong. I tested my August 4th build, this is before the change in ui organisation. However, I cannot grep fieldOffset in Draft_rc.py, seems like something qt-y went wrong in compiling Draft_rc, I think..

[hvfrancesco]

A small temporary workaround in the attached patch. not sure it's the right approach to it, but it's usable

[hvfrancesco]

This is a slightly better patch, that works with 3 points plane selection too and preserves the optional offset. It's still probably just a workaround because I suppose Yorik had not finished yet the refactoring, but it seems to work

[Roy_043]

@hvfrancesco:
Can you post the DraftSelectPlane.py file with your modifications? It would be very helpful as this bug is quite problematic for most Arch/BIM workflows.

[hvfrancesco]

Sure, here it is. Let me know if it works for you.

[bernd]

if it fixes the problem, it would be good to go for a PR on https://github.com/FreeCAD/FreeCAD/pulls