Link Merge: STEP import export enhancements

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
User avatar
easyw-fc
Posts: 2916
Joined: Thu Jul 09, 2015 9:34 am

Link Merge: STEP import export enhancements

Postby easyw-fc » Tue Oct 01, 2019 1:10 pm

With the recent Link Merge, also STEP import export has been improved a lot, getting new features from A3 branch.
First of all many thanks to @realthunder
realthunder wrote: ping
I have waited a bit, considering the big job you are doing fixing (not many) issues after the big Link Merge.
Now I would like to report some small issue that in A3 I didn't found:
1)
a) I'm using the file we used previously:
as1-ac-214.stp
if I import it enabling 'LinkGroup' in STEP preferences the file gets loaded fine
b) if I export as STEP the imported file, both enabling 'Legacy exporter' or disabling it, the exported file would loose colors.
c) if I import the file without enabling 'LinkGroup' in STEP preferences and export it as STEP enabling 'Legacy exporter', the exported file would keep colors.

2) Create simple copy in Part wb, will not copy color of i.e. the imported step model.

And just a simple remark...
I've noticed from my tests, that the most similar to commercial sw importing/exporting configuration for hierarchical models, seems to be the one in the attached image...
Feedback from other STEP users are welcome.
-
import-export-settings.png
import-export-settings.png (59.08 KiB) Viewed 957 times
I forgot my FC info:

Code: Select all

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18356 (Git)
Build type: Release
Branch: master
Hash: 12335c7d52376c140c5328d57902d2c0afdeb588
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)
realthunder
Posts: 1816
Joined: Tue Jan 03, 2017 10:55 am

Re: Link Merge: STEP import export enhancements

Postby realthunder » Wed Oct 02, 2019 9:27 am

This bug is fixed with this PR. Specifically, with this commit.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
pl7i92LCNC
Posts: 209
Joined: Tue Mar 12, 2019 3:03 pm
Location: RLP DE

Re: Link Merge: STEP import export enhancements

Postby pl7i92LCNC » Wed Oct 02, 2019 2:14 pm

as well as you may import to the part workbench and safe as a FC modell
this wil give you alot of options on the part itself
User avatar
easyw-fc
Posts: 2916
Joined: Thu Jul 09, 2015 9:34 am

Re: Link Merge: STEP import export enhancements

Postby easyw-fc » Thu Oct 03, 2019 10:10 am

realthunder wrote:
Wed Oct 02, 2019 9:27 am
This bug is fixed with this PR. Specifically, with this commit.
Thanks a lot for this fast fix :D

May I ask you, considering your work on STEP import/export, if you could have a look at this thread?
Loss of coordinate systems during .stp (AP214) import/export
It would be great to add both import and export LCS feature within STEP.
Image
From the thread here is a STEP file with named coordinate systems PCS,MCS,CSW -> #4082=AXIS2_PLACEMENT_3D('MCS',#5744,#4567,#4568)
mdel2.stp

This would also improve FC STEP interoperability and i.e. Asm4 WB, when playing with STEP models, instead of FC files.

Thanks in advance,
Maurice
User avatar
easyw-fc
Posts: 2916
Joined: Thu Jul 09, 2015 9:34 am

Re: Link Merge: STEP import export enhancements

Postby easyw-fc » Tue Oct 22, 2019 8:01 am

realthunder wrote:
Wed Oct 02, 2019 9:27 am
This bug is fixed with this PR. Specifically, with this commit.
easyw-fc wrote:
Tue Oct 01, 2019 1:10 pm
2) Create simple copy in Part wb, will not copy color of i.e. the imported step model.
Is the Simple Copy Part WB fixed?
If I try to make a simple copy, colors don't get copied...
simple-copy-not-colored.FCStd
(195.14 KiB) Downloaded 11 times

Code: Select all

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18568 (Git)
Build type: Release
Branch: master
Hash: 4614eb92a226b0da72320be8548fe0ebfbbe415a
Python version: 3.7.3
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)
realthunder
Posts: 1816
Joined: Tue Jan 03, 2017 10:55 am

Re: Link Merge: STEP import export enhancements

Postby realthunder » Wed Oct 23, 2019 1:22 am

easyw-fc wrote:
Tue Oct 22, 2019 8:01 am
Is the Simple Copy Part WB fixed?
If I try to make a simple copy, colors don't get copied...
I see. But the problem you mentioned is related to STEP import/export, which should be fixed now. Copying container does not have color support yet. Maybe you can check with 0.18 and see if there is any regression of color copying. I just found a regression about not copying the individual face DiffuseColor when copying a single Part object. This can be easily fixed. The color copy of a container, though, is a lot more complex. I did this using my topo naming feature. If this is really needed, maybe it's time to start merging my topo naming code upstream, at least part of it.
Try Assembly3 (latest version 0.11) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
easyw-fc
Posts: 2916
Joined: Thu Jul 09, 2015 9:34 am

Re: Link Merge: STEP import export enhancements

Postby easyw-fc » Thu Oct 24, 2019 9:03 pm

realthunder wrote:
Wed Oct 23, 2019 1:22 am
Copying container does not have color support yet. Maybe you can check with 0.18 and see if there is any regression of color copying. I just found a regression about not copying the individual face DiffuseColor when copying a single Part object. This can be easily fixed. The color copy of a container, though, is a lot more complex. I did this using my topo naming feature. If this is really needed, maybe it's time to start merging my topo naming code upstream, at least part of it.
Fixing the individual face color would be nice...
Regarding the issue I was comparing this behavior with your A3 branch (in which copy works also for Part containers) and I forgot you have not merged the topo naming feature.
I think it wold be great to have merged also topo naming in the 0.19 cycle ... but I'm not the one who is going to check the merging ...
So I just put my vote in favor of merging it :D