[MERGED] Merge Profile Tools

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

[MERGED] Merge Profile Tools

Post by dubstar-04 »

There is currently two profile operations in path:

1. Profile based in edges
2. Profile based on faces


Profile Tools.png
Profile Tools.png (10.78 KiB) Viewed 2532 times


Would there be any benefit or issues with merging these in to a single operation?

Thanks,

Dan
Last edited by dubstar-04 on Wed May 20, 2020 6:54 am, edited 1 time in total.
herbk
Veteran
Posts: 2660
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: Merge Profile Tools

Post by herbk »

Hi Dan,

what's the benefit to change things where the user is familiar with? The issue is: one click more to get the OP... ;)
Gruß Herbert
User avatar
dubstar-04
Posts: 698
Joined: Mon Mar 04, 2013 8:41 pm
Location: Chester, UK
Contact:

Re: Merge Profile Tools

Post by dubstar-04 »

herbk wrote: Tue Oct 08, 2019 4:16 pm Hi Dan,

what's the benefit to change things where the user is familiar with? The issue is: one click more to get the OP... ;)
It should be possible to merge the operations together so the code manages the choice between faces and edges depending on the users selection, like many other tools.

IMO it doesn't make sense this being two seperate operations and as we add operations to path the toolbars may become cluttered. See Arch for example as an extreme.

Just a thought.
herbk
Veteran
Posts: 2660
Joined: Mon Nov 03, 2014 3:45 pm
Location: Windsbach, Bavarya (Germany)

Re: Merge Profile Tools

Post by herbk »

dubstar-04 wrote: Tue Oct 08, 2019 4:24 pm It should be possible to merge the operations together so the code manages the choice between faces and edges depending on the users selection, like many other tools.
Oh, - there i take you wrong... If that is possible, nothing to say against it.
Gruß Herbert
mlampert
Veteran
Posts: 1772
Joined: Fri Sep 16, 2016 9:28 pm

Re: Merge Profile Tools

Post by mlampert »

dubstar-04 wrote: Tue Oct 08, 2019 4:24 pm It should be possible to merge the operations together so the code manages the choice between faces and edges depending on the users selection, like many other tools.

IMO it doesn't make sense this being two seperate operations and as we add operations to path the toolbars may become cluttered. See Arch for example as an extreme.
There are some peculiarities and extra functionality with ProfileFace, might be a bit tricky to consolidate the UI. Having said that, I'm all for it.
RatonLaveur
Posts: 991
Joined: Wed Mar 27, 2019 10:45 am

Re: Merge Profile Tools

Post by RatonLaveur »

As a heavy user, I'm all for it. Consolidated profile will be smart!
User avatar
sliptonic
Veteran
Posts: 3459
Joined: Tue Oct 25, 2011 10:46 pm
Location: Columbia, Missouri
Contact:

Re: Merge Profile Tools

Post by sliptonic »

Fewer tools are better as long a it's clear to the user. Go for it.
nahshon
Posts: 225
Joined: Wed Jul 24, 2013 8:06 pm

Re: Merge Profile Tools

Post by nahshon »

I agree with sliptonic.
The profile is based on what's selected, so there should not be a conflict.

If you are looking into it there is a feature request (IMHO valuable) - handle open paths! I want to be able to select one of more edges and create a tool path even when the esges do not form a closed path.

HeeksCAD & HeeksCNC could do it very well. IIRC there was a discussion in this forum.
Russ4262
Posts: 951
Joined: Sat Jun 30, 2018 3:22 pm
Location: Oklahoma
Contact:

Re: Merge Profile Tools

Post by Russ4262 »

RatonLaveur
Posts: 991
Joined: Wed Mar 27, 2019 10:45 am

Re: Merge Profile Tools

Post by RatonLaveur »

I'll go on a limb here and say for the whole community: thanks! Well done! And WoopDeeDoo!

Path is becoming one slick module with your undying motivation and selfless toils!

EDIT: this is a general "your" here targeted at Russ obviously but very much intended to pay respects to all other contributors...
Post Reply