Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

wmayer wrote: Tue Oct 15, 2019 6:19 pm
If we do a v0.18.4, I'd like to include this fix. Should I merge it now?
Yes. There are a few more fixes coming soon.
Except of one 0.19-specific change, the PR 2630 should be backported before a 0.18.4 release because it fixes 2 issues on installing 0.18.4 over 0.18.x.
vocx
Veteran
Posts: 5197
Joined: Thu Oct 18, 2018 9:18 pm

Re: Back port commits to 0.18 branch

Post by vocx »

uwestoehr wrote: Thu Oct 17, 2019 9:44 am Except of one 0.19-specific change, ...
Reference here: #2630 Win installer fixes
Except of this change:

Code: Select all

+ File /r "${FILES_FREECAD}\resources"
It must therefore also be backported to FC 0.18.
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

vocx wrote: Thu Oct 17, 2019 3:33 pm
uwestoehr wrote: Thu Oct 17, 2019 9:44 am Except of one 0.19-specific change, ...
Reference here: #2630 Win installer fixes
Thanks. I see now that the new Windows installer has not yet been backported for FC 0.18. Therefore there is nothing to be backported.
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote:ping
kkremitzki wrote:ping
triplus wrote:ping
How do you guys feel about creating the 0.18.4 tag?
"fight the good fight"
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Sat Oct 26, 2019 2:10 pm
looo wrote:ping
kkremitzki wrote:ping
triplus wrote:ping
How do you guys feel about creating the 0.18.4 tag?
For conda-forge based packages it makes more sense to do something like a 0.19.alpha release using any of the current 0.19.pre builds. These have quite some advantages over the 0.18 builds which rely on the older toolchain and uses qt-webkit.
User avatar
kkremitzki
Veteran
Posts: 2511
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: Back port commits to 0.18 branch

Post by kkremitzki »

Yeah, it looks like it's time.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote: Sat Oct 26, 2019 3:14 pm For conda-forge based packages it makes more sense to do something like a 0.19.alpha release using any of the current 0.19.pre builds. These have quite some advantages over the 0.18 builds which rely on the older toolchain and uses qt-webkit.
We will just point them to the 0.19_pre.
kkremitzki wrote: Sat Oct 26, 2019 5:06 pm Yeah, it looks like it's time.
OK
https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.4
I hope to fill it out by next weekend.
"fight the good fight"
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

Since we're not backporting many commits, we should at lease add a changelog explaining why these minor releases are happening?
We're pointing people to the Known Issues thread but that is pretty static. I think adding bullet point or each commit makes sense.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

BTW, distrowatch is also following our 0.18 tip :D
https://repology.org/project/freecad/badges
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

sgrogan wrote: Sat Oct 26, 2019 2:10 pm How do you guys feel about creating the 0.18.4 tag?
Well :)

For the Windows installer of 0.18.4 please assure that you take the latest installer version from the master branch because I recently fixed an issue when installing FC 0.18.x over an existing 0.18.x (This will be the case when users install 0.18.4 over their 0.18.x.)
Post Reply