Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

sgrogan wrote: Sat Oct 26, 2019 5:17 pm https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.4
I hope to fill it out by next weekend.
Heads up, the 0.18.4 revision number should be 16145 not 16131
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

Kunda1 wrote: Mon Oct 28, 2019 10:38 am Heads up, the 0.18.4 revision number should be 16145 not 16131
We need to disable the auto deploy for conda based builds based on looo's post above.
"fight the good fight"
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Tue Oct 29, 2019 11:01 pm
Kunda1 wrote: Mon Oct 28, 2019 10:38 am Heads up, the 0.18.4 revision number should be 16145 not 16131
We need to disable the auto deploy for conda based builds based on looo's post above.
I didn't mean to not create 0.18.4 builds which are hopefully uploaded soon.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

It's good that we're ironing out all these details and getting better at releases.
where's our checklist for such things?

For example on my end:
manuall update the script that updates(*) the AppImage page which is actually updating 2 wiki templates: And also submitting a PR to FreeCAD-Homepage
https://github.com/FreeCAD/FreeCAD-Home ... b701266046

* The script only tracks the development version not stable.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

My attempt to build 0.18.4 didn't succeed because of conda-build 3.18 introduced a slow-down during a library checking process and circle-ci stops the build because of "Too long with no output (exceeded 10m0s)".

ref.:
https://github.com/conda-forge/conda-bu ... issues/118
https://github.com/conda/conda-build/issues/3775

I will trigger the builds again once a new conda-build version is available.

edit.: After doing some modification to the build-scripts I was able to force conda using a conda-build-version other than 3.18.10. So 0.18.4 builds are uploaded and should be used for the next appimage/dmg.
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

looo wrote: Wed Oct 30, 2019 5:09 pm edit.: After doing some modification to the build-scripts I was able to force conda using a conda-build-version other than 3.18.10. So 0.18.4 builds are uploaded and should be used for the next appimage/dmg.
https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.4 :D @looo is awesome!
Kunda1 wrote: Mon Oct 28, 2019 10:38 am Heads up, the 0.18.4 revision number should be 16145 not 16131
0.18.16146?
"fight the good fight"
User avatar
kkremitzki
Veteran
Posts: 2511
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: Back port commits to 0.18 branch

Post by kkremitzki »

As much as I love juggling these 5-digit numbers I can't wait until we get them out of our release version numbers and back to referring to development builds only.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: Back port commits to 0.18 branch

Post by looo »

sgrogan wrote: Thu Oct 31, 2019 9:58 pm https://github.com/FreeCAD/FreeCAD/releases/tag/0.18.4 :D @looo is awesome!
Struggling with the weekly builds nearly every week, I didn't expect the old recipe to work out of the box...

Anyway osx is seeing brew-issues again. So this might need some time to be solved. (Last time we saw such errors it somehow got sorted by itself.)
https://travis-ci.org/FreeCAD/FreeCAD-A ... 7378#L3276
kkremitzki wrote: Thu Oct 31, 2019 11:29 pm As much as I love juggling these 5-digit numbers I can't wait until we get them out of our release version numbers and back to referring to development builds only.
Hmm, I think it shouldn't be too difficult to change this. But I do not really feel responsible for this part and changing this might break other stuff too. So I guess it's best to ask @triplus or @kunda to make this change.
triplus wrote:
Kunda1 wrote:
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

The stable builds shouldn't have revision numbers, IMO.
So I'm :+1: for removing them. Downstream package managers will adapt as well.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

Kunda1 wrote: Fri Nov 01, 2019 12:58 pm The stable builds shouldn't have revision numbers, IMO.
:+1: from me too.
Post Reply