Yes, such things usually sort themselves out, on Homebrew/Travis side. This time, due to the issue already persisting for around 10 days and due to point release just being made, i added a workaround, and macOS people can now join the party.
Yes, such things usually sort themselves out, on Homebrew/Travis side. This time, due to the issue already persisting for around 10 days and due to point release just being made, i added a workaround, and macOS people can now join the party.
I see, so we are talking about the version set in the version.h file. I thought this was about the file-name of the appimage/dmg.triplus wrote: ↑Sun Nov 03, 2019 12:23 amAs for the version number. Travis will set the package (version) name, based on whatever FreeCAD says the version is. I feel that this approach makes the most sense. Hence @looo would need to patch FreeCAD package on Conda side, and use some arbitrary version number, like for example 0.18.4. Currently packagers are resulting to all sort of hacks, trying to achieve that, i find that messy. This probably needs to get addressed upstream. By for example explicitly committing such value, at some point, to the 0.18 branch, and in such case, for it to be used automatically, when compiling the FreeCAD.
Nice! Thanks.
Yes, this is the main problem. We started doing point releases, some people would like for that to be reflected in FreeCAD version name, currently hacks are being used, to achieve such results, when creating the packages. In addition some scripts out there do check for the version name, not yet taking point release version name scheme into consideration. For example replacing revision number 16146 with a number such as 4, that i guess can make a script, expecting a higher number, to assume, older FreeCAD version is being run.
You're welcome.Nice! Thanks.
added:triplus wrote: ↑Mon Nov 04, 2019 12:28 amP.S. Just wondering, how hard would it be to create a Conda Linux FreeCAD 0.18.4 test package, containing this code changes:
https://github.com/FreeCAD/FreeCAD/blob ... istant.cpp
Great to see such patches can be applied in a rather straightforward fashion. I tested the FreeCAD 0.18.4 AppImage and unfortunately it still doesn't work. An additional quirk is involved somewhere, Qt Assistant doesn't want to unregistered the documentation and it doesn't provide a reason, on why it fails. Will do some more tests in the following days.looo wrote: ↑Mon Nov 04, 2019 11:41 amadded:
https://github.com/looooo/freecad-feeds ... 2718be5231
If it doesn't work we can move back to the origin 0.18.4 build.
Done!bernd wrote: ↑Fri Dec 20, 2019 10:04 ama reminder
git commit 7d96016
git commit f1a3a62
git commit 1f53e8b