Which FEM Analysis Icon is the one we use ?

About the development of the FEM module/workbench.

Moderator: bernd

vocx
Posts: 3253
Joined: Thu Oct 18, 2018 9:18 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby vocx » Sat Feb 15, 2020 1:27 am

In the source code, the file is called "fem-analysis.svg".

In the wiki all pages should start with a capital letter, so the wiki calls this file, "Fem-analysis.svg".

The icon "Fem_Analysis.svg" looks a bit bigger, and the color is a bit darker. Moreover, this icon is only used in what appears to be a test page by quick61 from 2014, Artwork_quick61_rework.

Therefore, I think the second of the icons that you present can be removed.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Which FEM Analysis Icon is the one we use ?

Postby bernd » Sat Feb 15, 2020 6:36 am

wait! The second one looks much better! I will have a look. Icons in FEM where renamed a few times.
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Which FEM Analysis Icon is the one we use ?

Postby bernd » Sat Feb 15, 2020 11:52 am

vocx wrote:
Sat Feb 15, 2020 1:27 am
The icon "Fem_Analysis.svg" looks a bit bigger, and the color is a bit darker. Moreover, this icon is only used in what appears to be a test page by quick61 from 2014, Artwork_quick61_rework.

Therefore, I think the second of the icons that you present can be removed.
It is the opposite! The second one is the one which is used in source code and which is therefor used in FreeCAD software. This should stay as it is in the wiki! https://github.com/FreeCAD/FreeCAD/blob ... alysis.svg
User avatar
Kunda1
Posts: 7010
Joined: Thu Jan 05, 2017 9:03 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby Kunda1 » Sat Feb 15, 2020 1:11 pm

bernd wrote:
Sat Feb 15, 2020 11:52 am
It is the opposite! The second one is the one which is used in source code and which is therefor used in FreeCAD software. This should stay as it is in the wiki! https://github.com/FreeCAD/FreeCAD/blob ... alysis.svg
:+1:
I'll remove the 1st icon then and re-name the link on the pages that use it.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
bernd
Posts: 9246
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: Which FEM Analysis Icon is the one we use ?

Postby bernd » Sat Feb 15, 2020 3:38 pm

great
vocx
Posts: 3253
Joined: Thu Oct 18, 2018 9:18 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby vocx » Sat Feb 15, 2020 3:53 pm

bernd wrote:
Sat Feb 15, 2020 11:52 am
... It is the opposite! The second one is the one which is used in source code ...
Well, I was talking about the page name, as that is what matters in the wiki.

The page "Fem-analysis.svg" should be kept. Of course, its content can be updated with the actual icon used in the source code but that's a trivial step.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
User avatar
Kunda1
Posts: 7010
Joined: Thu Jan 05, 2017 9:03 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby Kunda1 » Sun Feb 16, 2020 12:57 pm

Can we rename it in the source code then?
So it's all uniform ?
Aren't other icons using snake_case ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
vocx
Posts: 3253
Joined: Thu Oct 18, 2018 9:18 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby vocx » Sun Feb 16, 2020 4:44 pm

Kunda1 wrote:
Sun Feb 16, 2020 12:57 pm
...
Aren't other icons using snake_case ?
There is nothing standard in FreeCAD, in general. This is the reason we need to improve standardization across different workbenches.

In FEM, icons are like this.

Code: Select all

ls -1 src/Mod/Fem/Gui/Resources/icons/

Arch_Material_Group.svg
fem-add-fem-mesh.svg
fem-add-material.svg
fem-add-part.svg
fem-analysis.svg
fem-clipping-plane-add.svg
fem-clipping-plane-remove-all.svg
fem-constraint-bearing.svg
fem-constraint-contact.svg
fem-constraint-displacement.svg
fem-constraint-electrostatic-potential.svg
fem-constraint-fixed.svg
fem-constraint-flow-velocity.svg
fem-constraint-fluid-boundary.svg
fem-constraint-force.svg
fem-constraint-gear.svg
fem-constraint-heatflux.svg
fem-constraint-initial-flow-velocity.svg
fem-constraint-initial-temperature.svg
fem-constraint-planerotation.svg
fem-constraint-pressure.svg
fem-constraint-pulley.svg
fem-constraint-selfweight.svg
fem-constraint-temperature.svg
fem-constraint-transform.svg
fem-element-fluid-1d.svg
fem-element-geometry-1d.svg
fem-element-geometry-2d.svg
fem-element-rotation-1d.svg
fem-equation-elasticity.svg
fem-equation-electrostatic.svg
fem-equation-flow.svg
fem-equation-fluxsolver.svg
fem-equation-heat.svg
fem-femmesh-boundary-layer.svg
fem-femmesh-clear-mesh.svg
fem-femmesh-create-node-by-poly.svg
fem-femmesh-from-shape.svg
fem-femmesh-gmsh-from-shape.svg
fem-femmesh-netgen-from-shape.svg
fem-femmesh-print-info.svg
fem-femmesh-region.svg
fem-femmesh-result.svg
fem-femmesh-to-mesh.svg
fem-material-fluid.svg
fem-material-nonlinear.svg
fem-material-reinforced.svg
fem-material.svg
fem-post-data-pipline.svg
fem-post-filter-clip-region.svg
fem-post-filter-clip-scalar.svg
fem-post-filter-cut-function.svg
fem-post-filter-data-along-line.svg
fem-post-filter-data-at-point.svg
fem-post-filter-linearized-stresses.svg
fem-post-filter-warp.svg
fem-post-geo-box.svg
fem-post-geo-cylinder.svg
fem-post-geo-isosurface.svg
fem-post-geo-plane.svg
fem-post-geo-sphere.svg
fem-post-result-show.svg
fem-post-results-purge.svg
fem-solver-analysis-frequency.svg
fem-solver-analysis-static.svg
fem-solver-analysis-thermomechanical.svg
fem-solver-control.svg
fem-solver-elmer.svg
fem-solver-inp-editor.svg
fem-solver-run.svg
fem-solver-standard.svg
FemWorkbench.svg
preferences-fem.svg
I believe TechDraw used to have a similar style; that was until Uwe made a pull request to rename a bunch of files and fix the source code. It can be done, but it's hard work.
Always add the important information to your posts if you need help.
To support the documentation effort, and code development, your donation is appreciated: paypal.
User avatar
Kunda1
Posts: 7010
Joined: Thu Jan 05, 2017 9:03 pm

Re: Which FEM Analysis Icon is the one we use ?

Postby Kunda1 » Tue Feb 18, 2020 2:57 pm

bernd wrote:
Sat Feb 15, 2020 3:38 pm
Is this a project that someone int the FEM community would be able to tackle before the upcoming release in April ? It would be very good to uniform the documentation as best as possible before that.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features