thanks fc_tofu, I agree with what you point out, but that's beyond my possibilities ATM. Consider that with this PR it will be more difficult to delete the units in the inputfields since just the numerical part will be selected by default.fc_tofu wrote: ↑Fri Feb 14, 2020 4:28 pm Other issues I thought as limitation of FC coordinate, pls give some consideration.
1. DraftWB, if you enter a unitless number, FC treat it as "mm", not prefered-unit-system, ie, MKS (Preferences>General>Unit>Unit system).
2. Most workbenches (PartWB/PartDesignWB/Sketcher/TechDraw), donnot take prefered-unit-system as a matter. They alway use "mm", or adatpive unit in some cases.
3. FC saves prefered-unit-system in Preferences ("user.cfg"), which is not as convinient as file properties (.FCStd), IMHO.
[ Fixed ] [ Bug ] Draft problem with coordinate input
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: [ Bug ] Draft problem with coordinate input
follow my experiments on BIM modelling for architecture design
Re: [ Bug ] Draft problem with coordinate input
ok, thank you.carlopav wrote: ↑Fri Feb 14, 2020 5:21 pmthanks fc_tofu, I agree with what you point out, but that's beyond my possibilities ATM. Consider that with this PR it will be more difficult to delete the units in the inputfields since just the numerical part will be selected by default.fc_tofu wrote: ↑Fri Feb 14, 2020 4:28 pm Other issues I thought as limitation of FC coordinate, pls give some consideration.
1. DraftWB, if you enter a unitless number, FC treat it as "mm", not prefered-unit-system, ie, MKS (Preferences>General>Unit>Unit system).
2. Most workbenches (PartWB/PartDesignWB/Sketcher/TechDraw), donnot take prefered-unit-system as a matter. They alway use "mm", or adatpive unit in some cases.
3. FC saves prefered-unit-system in Preferences ("user.cfg"), which is not as convinient as file properties (.FCStd), IMHO.
Whith your fix applied on my machine, normal input unit can avoid focus as this fix's intention. But, with x/y/z constraint, unit focus issue still exist.
version: FreeCAD_0.19.19510_x64_LP_12.1.2_PY3QT5-WinVS2015
os: win10x64
Re: [ Bug ] Draft problem with coordinate input
PR has been merged now by Yorik, can you please check next build and report if it's ok for you?
follow my experiments on BIM modelling for architecture design
Re: [ Bug ] Draft problem with coordinate input
I also wanted to mention this.
Please check that your code was merged correctly. Some of my pull requests were merged as well, but there are others pending.
I have to rebase a few of my requests because now they conflict with DraftTools, DraftEdit, and DraftGui. I have to check this so that I don't accidentally override your changes.
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
Re: [ Bug ] Draft problem with coordinate input
Seems so. ATM the upstream code seems ok with my changes on DraftGui, init_tools and DraftEdit.
follow my experiments on BIM modelling for architecture design
Re: [ Bug ] Draft problem with coordinate input
Thanks for your work.
What release number should I be looking for?
FreeCAD_0.19.?????_x64_LP_12.1.2_PY3QT5-WinVS2015.7z
Re: [ Bug ] Draft problem with coordinate input
I dont know...
follow my experiments on BIM modelling for architecture design
Re: [ Bug ] Draft problem with coordinate input
Carlo's latest commit was git commit 8fd55eb6. See https://github.com/FreeCAD/FreeCAD/commits/8fd55eb6.
Code: Select all
git rev-list --count 8fd55eb6
20013
Always add the important information to your posts if you need help. Also see Tutorials and Video tutorials.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
To support the documentation effort, and code development, your donation is appreciated: liberapay.com/FreeCAD.
Re: [ Bug ] Draft problem with coordinate input
thx, don't know how to get it from gitKraken...
follow my experiments on BIM modelling for architecture design
Re: [ Bug ] Draft problem with coordinate input
You can't in gitkraken, but you can Invoke a terminal via the gitkraken alt+t shortcut. It will open a terminal who's current working directory will be the directory that you've cloned the repo into. Then just copy/paste the above code vocx provided.
Edit: spelling
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs