[WIP] updating to netgen 6.2.2004 (was smesh windows problem)

[looo]

Maybe someone can give me a hint what this means. I tried to rerun the smesh windows build.

Code: Select all

error LNK2019: unresolved external symbol __imp_gethostname referenced in function "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl GetHostname(void)" (?GetHostname@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ)
SMESHMisc.dll : fatal error LNK1120: 1 unresolved externals

[sgrogan]

Maybe someone can give me a hint what this means. I tried to rerun the smesh windows build.

Maybe this offers a hint?
https://www.experts-exchange.com/questi ... ame-8.html

Hi ,

you'll have to link with Ws2_32.lib ... simply open 'Project->Settings' dialog, select 'Link'-tab
and add Ws2_32.lib to 'Object/library modules'.

hope that helps,

ZOPPO

https://developercommunity.visualstudio ... -c-in.html

[triplus]

Sometimes on Linux such outcome signals a borked build, starting fresh usually helps.

[looo]

Sometimes on Linux such outcome signals a borked build, starting fresh usually helps.

Already tried 3 times. I guess it's a problem of VisualStudio setup on azure or it is related to the used compiler-package. The update I wanted to make is not very important. Only pinning netgen tightly to smesh to make sure smesh doesn't pull a newer version of netgen if we update netgen. I tried updating netgen recently (6.2.1808 ->6.2.2004) but netgen changed the interface which makes smesh incompatible...

[triplus]

I guess the question is why are we talking about a 32 bit network oriented library in the first place. I would say try what @sgrogan suggested if you have "settings dialog" at your disposal? Reading this:

Ensure that the build environment links to the Winsock Library file Ws2_32.lib.

https://docs.microsoft.com/en-us/window ... pplication

This is therefore indeed what is likely missing. If the actual file is missing, then it is likely a part or some SDK, or you would need to define ws2_32.lib somewhere, as a dependency. Just guessing, as i have no experience with such toolchain.

[triplus]

If you have a chance to install "Desktop development with C++" workload, do that. As maybe the mentioned library will be a part of that workload.

[looo]

Ensure that the build environment links to the Winsock Library file Ws2_32.lib.

Maybe someone can give me a hint what this means. I tried to rerun the smesh windows build.

Maybe this offers a hint?
https://www.experts-exchange.com/questi ... ame-8.html

Hi ,

you'll have to link with Ws2_32.lib ... simply open 'Project->Settings' dialog, select 'Link'-tab
and add Ws2_32.lib to 'Object/library modules'.

hope that helps,

ZOPPO

https://developercommunity.visualstudio ... -c-in.html

You were right. It seems like the library was linked in automatically previously but this has changed. The build is fixed with this little patch:
https://github.com/conda-forge/smesh-fe ... nker.patch

[triplus]

Great!

[looo]

question to the c++ experts:

Netgen has changed the interface to this:

Code: Select all

geo->SetOCCParameters(occparam);
auto mesh = make_shared<Mesh>();
geo->GenerateMesh(mesh, mp);
mesh->SetGeometry(geo);
SetGlobalMesh(mesh);

which previously looked like this:

Code: Select all

DLL_HEADER extern int OCCGenerateMesh(OCCGeometry&, shared_ptr<Mesh>&, MeshingParameters&);

Whats the easiest way to align to the new interface? Does it make sense? Or should we use the python bindings they provide to interface the meshing functionality?

[wmayer]

Whats the easiest way to align to the new interface?

An option might be to add an implementation of OCCGenerateMesh to NETGENPlugin_Mesher.cxx in order to reduce the amount of changes. It could look like this:

Code: Select all

int OCCGenerateMesh(OCCGeometry& geo, shared_ptr<Mesh>& mesh, MeshingParameters& mp)
{
    auto value = geo.GenerateMesh(mesh, mp);
    mesh->SetGeometry(geo);
    return value;
}

Or should we use the python bindings they provide to interface the meshing functionality?

I wouldn't do that because it could become quite inefficient because the functions which call OCCGenerateMesh can be invoked many times.

Is SetOCCParameters a new function and if yes what's the type of occparam?