GSoC Proposal: Extended functionality of Rebar Addon

A forum dedicated to the Draft, Arch and BIM workbenches development.
User avatar
Suraj Dadral
Posts: 279
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Thu Jul 09, 2020 10:03 pm

bernd wrote:
Thu Jul 09, 2020 2:36 pm
@balbros: thanks

in the regard of the views ... it should be possible not to show all rebars. See attached side view of a wall. A column would be similar.
Hi @bernd, @balrobs and @hardeeprai

For now, I created above issue here to do it later.

Thanks.
User avatar
hardeeprai
Posts: 176
Joined: Sun May 23, 2010 2:41 pm
Location: Ludhiana, Punjab, India
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby hardeeprai » Fri Jul 10, 2020 2:16 am

balrobs wrote:
Thu Jul 09, 2020 1:22 pm
It's a 2D reinforcement software which treats individual reinforcements in the different views ...
May I know the name of the software?
--
H.S.Rai
balrobs
Posts: 79
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Fri Jul 10, 2020 2:32 pm

hardeeprai wrote:
Fri Jul 10, 2020 2:16 am
balrobs wrote:
Thu Jul 09, 2020 1:22 pm
It's a 2D reinforcement software which treats individual reinforcements in the different views ...
May I know the name of the software?
The name is DIG CAD. it has been used in our office for many years and we are very satisfied with it. However, there is no 3D modeling with it, all reinforcements are drawn in 2D with the support of the software and your imagination.
User avatar
amrit3701
Posts: 303
Joined: Mon Jun 13, 2016 5:37 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby amrit3701 » Wed Jul 22, 2020 7:13 pm

@Suraj,

Any updates/progress on dimensions? If you stuck in any problem please share here (don't hesitate to ask for help ;) ). Feedback from the community is very important to be a successful GSoC project.

Also, please updates your logs: https://wiki.freecadweb.org/User:Suraj_ ... SoC20/logs
User avatar
Suraj Dadral
Posts: 279
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Wed Jul 22, 2020 9:09 pm

amrit3701 wrote:
Wed Jul 22, 2020 7:13 pm
@Suraj,

Any updates/progress on dimensions? If you stuck in any problem please share here (don't hesitate to ask for help ;) ). Feedback from the community is very important to be a successful GSoC project.
Hi @all

Sorry for being late to report here. Here are updates:
1. Create parametric object for reinforcement dimensioning as per this commit.
For automated dimensioning, we will be creating new dimension object for each rebar dimensioning. Although, this may increase the number of objects in document, but the benefit of using this method will be that user will be able to delete or modify generated dimensioning for each rebar.
2. [WIP] Create stirrup dimensioning as per this commit.
Sample output:
test_stirrup_dim.png
test_stirrup_dim.png (83.34 KiB) Viewed 353 times
amrit3701 wrote:
Wed Jul 22, 2020 7:13 pm
Also, please updates your logs: https://wiki.freecadweb.org/User:Suraj_ ... SoC20/logs
Will update it soon. (by today)

Thanks,
User avatar
Suraj Dadral
Posts: 279
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Thu Jul 23, 2020 8:21 pm

Hi all,

Update: Implement Stirrup labeling in Top/Bottom views.
- Implement adding Rebar Mark in dimension label
- Remove "Font" and "FontSize" property from ReinforcementDrawing object as this part is required in ReinforcementDimension object and is already there.
- Return drawing page object from function makeReinforcementDrawing() instead of only drawing svg.
- Add left/right/top/bottom offset point in ReinforcementDrawing and ReinforcementDimension objects to use for automated dimensioning. In ReinforcementDrawing object, these will points to next point that can be used to place reinforcement dimension label.

Sample output:
test_stirrup_dim.png
test_stirrup_dim.png (41.75 KiB) Viewed 308 times

In above, if stirrup span axis is parallel to drawing plane normal, then stirrup dimension/label is placed mid point of middle edge of stirrup.

We can also do it like below:
test_stirrup_dim.png
test_stirrup_dim.png (43.21 KiB) Viewed 308 times

Please, let me know which way looks good or we need to some modification.

To display rebar mark in above, I used DimensionFormat="%M %C%D" (M->rebar.Mark, C->rebar.Amount, D->rebar.Diameter). And added Mark property manually into Rebar objects.
I will make PR into FreeCAD repo, if adding Mark property (of type string) to rebar objects is fine.

Thanks,
User avatar
Suraj Dadral
Posts: 279
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Thu Jul 23, 2020 9:51 pm

Suraj Dadral wrote:
Thu Jul 23, 2020 8:21 pm
I will make PR into FreeCAD repo, if adding Mark property (of type string) to rebar objects is fine.
Added Mark property to ArchRebar object as of this commit: https://github.com/SurajDadral/FreeCAD/ ... 008b43b491

Please check if this is right, I will create PR to FreeCAD repo then.

Thanks,
User avatar
amrit3701
Posts: 303
Joined: Mon Jun 13, 2016 5:37 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby amrit3701 » Fri Jul 24, 2020 7:19 am

Suraj Dadral wrote:
Thu Jul 23, 2020 9:51 pm
Added Mark property to ArchRebar object as of this commit: https://github.com/SurajDadral/FreeCAD/ ... 008b43b491

Please check if this is right, I will create PR to FreeCAD repo then.
Create PR, please!
User avatar
Suraj Dadral
Posts: 279
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby Suraj Dadral » Fri Jul 24, 2020 9:53 am

amrit3701 wrote:
Fri Jul 24, 2020 7:19 am
Suraj Dadral wrote:
Thu Jul 23, 2020 9:51 pm
Added Mark property to ArchRebar object as of this commit: https://github.com/SurajDadral/FreeCAD/ ... 008b43b491

Please check if this is right, I will create PR to FreeCAD repo then.
Create PR, please!
It's done: https://github.com/FreeCAD/FreeCAD/pull/3730

Thanks,
balrobs
Posts: 79
Joined: Fri Apr 24, 2020 8:58 pm

Re: GSoC Proposal: Extended functionality of Rebar Addon

Postby balrobs » Fri Jul 24, 2020 2:12 pm

Hi @Suraj
Suraj Dadral wrote:
Thu Jul 23, 2020 8:21 pm
Please, let me know which way looks good or we need to some modification.
IMHO the second way of dimensioning stirrups is more understandable. I've noticed that text sizes are different for both picture. In the first pic all views use the same font size. This is not true for the second pic. I think "equivalent" labels should have same text height and it should not depend on view scale.
BTW I tried to install your latest branch-dimensioning for testing it but I failed using the following code:

Code: Select all

from ReinforcementDrawing import make_reinforcement_drawing
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Front")
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Rear")
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Left")
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Right")
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Top")
make_reinforcement_drawing.makeStructuresReinforcementDrawing(view="Bottom")
Obviously this depends on some last changes ... Could you please give me a hint how to test the new feature?
Thank you!