[Merged] Missing Icons for Points Workbench

[Kunda1]

Anyone interested in creating icons for these missing functions in the Points Workbench ?

• Convert to points (Points Convert)
• Structured point cloud (Points Structure)
• Merge point clouds (Points Merge)

[bitacovir]

Anyone interested in creating icons for these missing functions in the Points Workbench ?

• Convert to points (Points Convert)
• Structured point cloud (Points Structure)
• Merge point clouds (Points Merge)

I just finished with Std Tool icons. Do you want me to take this?

[Kunda1]

I just finished with Std Tool icons. Do you want me to take this?

Nice! Thank you for your work!
If you have some time, that would be fantastic! But no rush and please pace yourself.

[bitacovir]

Proposal of icon for Convert to points command http://www.freecadweb.org/wiki/Points%20Convert

inkscape_Y67cPnQ0uc.png (19.36 KiB) Viewed 1570 times

.
.
Proposal of icon for Structured point cloud command http://www.freecadweb.org/wiki/Points%20Structure

inkscape_4ppvWQ35At.png (12.77 KiB) Viewed 1570 times

.
.
Proposal of icon for Merge point clouds command http://www.freecadweb.org/wiki/Points%20Merge

inkscape_9NHJr6bk8b.png (13.15 KiB) Viewed 1570 times

[Kunda1]

Nice work! They all look great to me.

[bitacovir]

Nice work! They all look great to me.

Good. I'll do a PR next week.

[HakanSeven12]

Hi nice work but if I remember correctly, this commands not added to toolbar. They could be added to a new toolbar.

[bitacovir]

Hi nice work but if I remember correctly, this commands not added to toolbar. They could be added to a new toolbar.

I don't know how to do that. Only I know how to link the command with the svg icon in the menus.

[HakanSeven12]

Me too I don't have any experience on c++ workbenches.

[Kunda1]

I don't have experience either but if we extrapolate from previous commits we can see that:

• each c++ workbench has a src/Mod/Points/<Workbenchname>/Gui/ directory
• SVG Icons are put in Gui/Resources/Icons
• Icon names are also registered in the src/Mod/<WBname>Gui/Resources/<WBname>.qrc
• Each command function has a sPixmap variable that needs to match the name of the svg icon in the Icons/ directory
• The commands are then registered in src/Mod/<WBname>/Gui/Workbench.cpp in order to display then in the GUI.
  Note: We can see from src/Mod/<WBname>/Gui/Workbench.h that there are functions to add commands and their icons to

  Code: Select all

    Gui::ToolBarItem* setupToolBars() const;
    Gui::ToolBarItem* setupCommandBars() const;
    Gui::MenuItem* setupMenuBar() const;
  

  This probably means we can choose to add the commands to different parts of the GUI. ToolBar, the CommandBar(not sure what this means) and MenuBar(Drop down menu associated with the WBname)
  In more complex workbenches that have elaborate toolbars (like sketcher) it's possible to create multiple toolbars. Looks like they need to be registered in Workbench.h and then built in Workbench.cpp
  
  Source: https://github.com/FreeCAD/FreeCAD/comm ... 3cc94d9bfb