[ Bug ] "Show Fill" in ArchView-TechDraw no longer works

A forum dedicated to the Draft, Arch and BIM workbenches development.
paullee
Posts: 3348
Joined: Wed May 04, 2016 3:58 pm

[ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby paullee » Wed Apr 07, 2021 9:27 pm

It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView :)

Tested with below AppImages on Fedora 31

Not Working
FreeCAD_0.19-24276-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23756-Linux-Conda_glibc2.12-x86_64.AppImage

Working
FreeCAD_0.19-23578-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-23258-Linux-Conda_glibc2.12-x86_64.AppImage
FreeCAD_0.19-21775-Linux-Conda_glibc2.12-x86_64.AppImage

Screenshot from 2021-04-08 05-11-58.png
Screenshot from 2021-04-08 05-11-58.png (229.35 KiB) Viewed 328 times
Screenshot from 2021-04-08 05-12-02.png
Screenshot from 2021-04-08 05-12-02.png (261.34 KiB) Viewed 328 times

OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: (HEAD detached at 0.19.1)
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.8
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)


OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23756 (Git) AppImage
Build type: Release
Branch: master
Hash: 9c6e9184930a52b165a0b7274e3a45d1006bfe67
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)


OS: Fedora 31 (Workstation Edition) (GNOME/gnome)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23578 (Git) AppImage
Build type: Release
Branch: master
Hash: 50c3cbf00579dc4941ca743c25720d016b0453ce
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: English/United States (en_US)
User avatar
bitacovir
Posts: 1417
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby bitacovir » Wed Apr 07, 2021 10:31 pm

paullee wrote:
Wed Apr 07, 2021 9:27 pm
It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView
I confirm with FC 0.20 in windows

OS: Windows 10 Version 1909
Word size of FreeCAD: 64-bit
Version: 0.20.24587 (Git)
Build type: Release
Branch: master
Hash: 1f62d4666102d8efd4d8f3ba58a1037456a3bcfb
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/United States (en_US)
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My personal web site
My GitHub repository
My old Blog
Mini Airflow Tunnel Project
Syres
Posts: 986
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby Syres » Thu Apr 08, 2021 9:32 am

paullee wrote:
Wed Apr 07, 2021 9:27 pm
It seems Show Fill set to True no longer works for ArchWall in TechDraw with ArchView :)
The commit that appears to have caused the regression is git commit d7692e3 so I think @yorik would need to be involved in a fix so what he was trying to achieve isn't re-broken!! Copying the old ArchSectionPlane.py over the new one worked for me, what confused me on testing was that when I opened your file ArchView was set to Wireframe and not Solid.
User avatar
bitacovir
Posts: 1417
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby bitacovir » Thu Apr 08, 2021 12:34 pm

I left a message in the commit linking to this thread. If Yorik is too busy we just could leave a report in the bugtracker.
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My personal web site
My GitHub repository
My old Blog
Mini Airflow Tunnel Project
Syres
Posts: 986
Joined: Thu Aug 09, 2018 11:14 am

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby Syres » Thu Apr 08, 2021 1:29 pm

All I did was change line 456 of src\Mod\Arch\ArchSectionPlane.py from:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#ffffff")
which is pure white (and so looks like it's not working but it is really) to:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#d6d6d6")
which is the same as 'sectionfill' but I suppose unless we know what the exact fault was that caused the change then we won't know if a PR is worth raising.
paullee
Posts: 3348
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby paullee » Thu Apr 08, 2021 2:46 pm

Probably @Yorik want to achieve to use colour of the object for the fill colour (announced somewhere and probably in wikj) he did the change ?

And Solid is kind of buggy to my memory as @Yorik explained.

On the move, see what we can do later.

Probably ping him or leave a bug report :D
paullee
Posts: 3348
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby paullee » Thu Apr 08, 2021 2:49 pm

p.s.

Now it make sense -

So if the Wall / Object colour is white (or same colour as TechDraw background) i.e. White, it should default to say Gray, otherwise the current regression.
paullee
Posts: 3348
Joined: Wed May 04, 2016 3:58 pm

Re: [ Bug ] "Show Fill" in ArchView-TechDraw no longer works

Postby paullee » Thu Apr 08, 2021 11:54 pm

Syres wrote:
Thu Apr 08, 2021 1:29 pm
which is pure white (and so looks like it's not working but it is really) to:

Code: Select all

            svgcache += render.getSectionSVG(linewidth="SVGCUTLINEWIDTH",fillpattern="#d6d6d6")
Without attempt to check the code :), I do further test:-
  1. A Material is created with name of 'Concrete'
  2. Color is Red, Section Colour is Blue
  3. Assign to the Wall object
  4. Workaround some Recompute bugs (e.g. needs turn on Fuse Arch, and turn it off to trigger 'real compute')
  5. Now ArchView show Section Colour :D
Screenshot from 2021-04-09 07-38-37.png
Screenshot from 2021-04-09 07-38-37.png (273.88 KiB) Viewed 125 times
Screenshot from 2021-04-09 07-38-56.png
Screenshot from 2021-04-09 07-38-56.png (278.78 KiB) Viewed 125 times
Screenshot from 2021-04-09 07-39-04.png
Screenshot from 2021-04-09 07-39-04.png (268.1 KiB) Viewed 125 times
Screenshot from 2021-04-09 07-40-11.png
Screenshot from 2021-04-09 07-40-11.png (264.43 KiB) Viewed 125 times