TechDraw Multithread Testing

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

wmayer wrote: Mon Aug 22, 2022 8:25 pm
I notice we're now using QFutureWatcherBase instead of QFutureWatcher. Just curious, why? Google didn't find much on QFutureWatcherBase.
wmayer
Founder
Posts: 20309
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Multithread Testing

Post by wmayer »

wandererfan wrote: Wed Aug 24, 2022 12:34 am I notice we're now using QFutureWatcherBase instead of QFutureWatcher. Just curious, why? Google didn't find much on QFutureWatcherBase.
No, we don't.

Code: Select all

    connectDetailWatcher = QObject::connect(&m_detailWatcher, &QFutureWatcherBase::finished, [this] {
        this->onMakeDetailFinished();
    });
The &QFutureWatcherBase::finished is only a function pointer, i.e. it's a static structure. Relevant is the type of m_detailWatcher and this is still a QFutureWatcher<void>. Dito for the other cases where QFutureWatcherBase is used.

Instead of the above you can also write

Code: Select all

    connectDetailWatcher = QObject::connect(&m_detailWatcher, &QFutureWatcher<void>::finished, [this] {
        this->onMakeDetailFinished();
    });
which doesn't make any difference.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Multithread Testing

Post by uwestoehr »

Kunda1 wrote: Thu Aug 18, 2022 3:26 pm This is probably due to the plan that the next version will be v1.0 Release_notes_1.0. Thanks for the heads up.
CC @uwestoehr, should we update the PR template to link to 1.0 Release notes?
Yes, please. Could you do it or make a PR?
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Multithread Testing

Post by Kunda1 »

uwestoehr wrote: Thu Aug 25, 2022 9:15 pm Yes, please. Could you do it or make a PR?
issue #7398
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Tandini
Posts: 37
Joined: Sat Jul 09, 2016 6:14 pm

Re: Multithread Testing

Post by Tandini »

wandererfan wrote: Tue Aug 16, 2022 5:48 pm I haven't heard any feedback from Windows (or mac) users ...
Kunda1 wrote: Tue Aug 16, 2022 6:42 pm Unfortunately, pushing to master it the least ideal but most optimal way to get testers :lol: :roll: :cry:
Eventually we'll have a service where we can build cross-platform experimental builds per PR (not just Linux Snap for the time being)
I read through this thread - but couldn't find a 'simple to use' source for a non-coder e.g. like weekly, to test that out with Windows :cry:
Any chance :?: :ugeek: :mrgreen:
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: TechDraw Multithread Testing

Post by Kunda1 »

We don't have a way (yet) to build windows test builds. We're discussing it. Hey @sliptonic, where's the discussion happening again?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
wandererfan
Veteran
Posts: 6321
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Multithread Testing

Post by wandererfan »

Tandini wrote: Mon Oct 24, 2022 6:25 am I read through this thread - but couldn't find a 'simple to use' source for a non-coder e.g. like weekly, to test that out with Windows :cry:
Any chance :?: :ugeek: :mrgreen:
Multithreading is in master. Any recent build should have it.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Multithread Testing

Post by uwestoehr »

wandererfan wrote: Mon Oct 24, 2022 2:46 pm Multithreading is in master. Any recent build should have it.
Yes, you can use any of these builds:
https://github.com/FreeCAD/FreeCAD-Bund ... kly-builds
User avatar
Tandini
Posts: 37
Joined: Sat Jul 09, 2016 6:14 pm

Re: TechDraw Multithread Testing

Post by Tandini »

Yeah, on updating to the latest weekly I realised that. Am just overwhealmed ;) :ugeek: :mrgreen: :thumbsup: :thumbsup: :thumbsup:
m1cha1
Posts: 25
Joined: Sun Oct 28, 2018 8:55 am

Re: TechDraw Multithread Testing

Post by m1cha1 »

I have one bug and one future request.
Bug:
Open some big drawing
Techdraw/Insert Page
Techdraw/Insert Projection group (select few projections)-CPU Load 40%
In the tree view delete ProjGroup
CPU Load is still 40% so Freecad is still working
After some time you will have information:
Unhandled Base::Exception caught in GUIApplication::notify.
The error message is: Access violation

CPU Load is still 40%
You can't close Freecad because it looks like Freecad must finnish all processes.

Feature request:
If you insert Projection group (or view) there is no information that something is working (except CPU load). I think it will be good to have some indicator or message about the ongoing process.
Maybe it's even better to have it globally for all workbenches some kind of process manager.

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.30716 (Git)
Build type: Release
Branch: master
Hash: cbd19631428f1d9eb4faae30220551608a648589
Python 3.10.6, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: Polish/Poland (pl_PL)
Thank you for your hard work
Post Reply