Wavefront OBJ exporter

[vocx]

...
Pasteing the same in code tags fixes it?

Oh, this is very bad. Indeed spaces and tabs shouldn't be mixed. It's not fixed, the tabs are still there, although both the forum and GitHub display them as 8 spaces by default. If you can submit a pull request for that, that would be good. Four spaces indentation should be the norm. That's what is used in the big Python workbenches like Draft, Arch, and FEM.

Just posted my code through PR #2593. It is improving current implementation into Arch

Ping.

[yorik]

Fixed in git commit 04f87588b0

[wmayer]

Oh, this is very bad. Indeed spaces and tabs shouldn't be mixed. It's not fixed, the tabs are still there, although both the forum and GitHub display them as 8 spaces by default

When looking at the code of the PR you can see that the indentation is inconsistent and when selecting the highlighted code you can see that these are tabs.

Anyway, it's good that Py3 raises an error now compared to Py2 where this was allowed. There the behaviour could be quite unexpected when in the editor tab size is set to 4 characters instead of 8.

[vocx]

Fixed in git commit 04f87588b0

I think the fix isn't entirely correct.

It should be

Code: Select all

if not curves:
    myshape = obj.Shape.copy(False)
    myshape.Placement=obj.getGlobalPlacement()
    mesh=MeshPart.meshFromShape(Shape=myshape, LinearDeflection=0.1, AngularDeflection=0.7, Relative=True)

and

Code: Select all

except: # unimplemented curve type
    myshape = obj.Shape.copy(False)
    myshape.Placement=obj.getGlobalPlacement()
    mesh=MeshPart.meshFromShape(Shape=myshape, LinearDeflection=0.1, AngularDeflection=0.7, Relative=True)

[sgrogan]

https://github.com/FreeCAD/FreeCAD/pull/2606