Helping to review pull requests

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Helping to review pull requests

Post by yorik » Fri Jul 17, 2020 1:37 pm

spanner888 wrote:
Thu Jul 09, 2020 11:27 am
and please add spanner888 on github
Done!

markus23
Posts: 11
Joined: Sun May 24, 2020 11:35 am

Re: Helping to review pull requests

Post by markus23 » Fri Jul 24, 2020 5:33 pm

Please add also me: markus2330

Thank you ;)

User avatar
vanuan
Posts: 465
Joined: Wed Oct 24, 2018 9:49 pm

Re: Helping to review pull requests

Post by vanuan » Tue Jul 28, 2020 11:38 pm

GitHub username: vanuan

Experienced programmer having some spare time due to pandemic.

TheMarkster
Posts: 2048
Joined: Thu Apr 05, 2018 1:53 am

Re: Helping to review pull requests

Post by TheMarkster » Fri Jul 31, 2020 3:16 am

yorik wrote: pinged by pinger macro
Add me github user mwganson
My FreeCAD video series on youtube: https://www.youtube.com/c/mwganson

marioalexis
Posts: 12
Joined: Wed Jun 19, 2019 7:44 pm

Re: Helping to review pull requests

Post by marioalexis » Sun Aug 02, 2020 3:25 am

Hi
user marioalexis84

User avatar
freman
Posts: 1270
Joined: Tue Nov 27, 2018 10:30 pm

Re: Helping to review pull requests

Post by freman » Wed Aug 05, 2020 9:18 pm

Not making any promises but I can see this may help speed up PRs getting processed.
J-Dunn on github.

I assume that members of this new group will not actually be able to merge, just post a +ve or -ve review: a bit like peer review for PRs. Sounds like a good idea. I hope it works better than peer review !

ezzieyguywuf
Posts: 656
Joined: Tue May 19, 2015 1:11 am

Re: Helping to review pull requests

Post by ezzieyguywuf » Mon Aug 17, 2020 4:07 pm

I'd like to read-through PR's and provide comments, though I don't currently have a dev environment set up to compile FreeCAD.

Would that be helpful? If so, please add ezzieyguywuf on github.

edit: NVM, it seems I can already do reviews for some reason.

See PR 3804 for an example of the type of help/reviews I can provide.

Please let me know if this is helpful, or if it is more preferable to compile/test the code (which I cannot conveniently do at the moment).

edit2: is it possible to add some more tags to the PR's? i.e. something like "partially reviewed" and "fully reviewed"?

I found the "On Hold" tag very helpful when skimming through, trying to find things to review. Other than that, though, I have no indication of whether or not any particular PR needs a review. I can take a guess based on the number of comments, but I doubt that's a very effective way to determine where reviews are needed.

chrisb
Posts: 28938
Joined: Tue Mar 17, 2015 9:14 am

Re: Helping to review pull requests

Post by chrisb » Wed Aug 19, 2020 11:45 am

ezzieyguywuf wrote:
Mon Aug 17, 2020 4:07 pm
Would that be helpful?
As an experienced FreeCAD programmer it would be great if you could have a look at realthunder's pending fixes for the Expression engine. That PR seems to be one of the showstoppers for a 0.19 stable.
A Sketcher Lecture with in-depth information is available in English, auf deutsch, en français, en español.

ezzieyguywuf
Posts: 656
Joined: Tue May 19, 2015 1:11 am

Re: Helping to review pull requests

Post by ezzieyguywuf » Wed Aug 19, 2020 12:04 pm

chrisb wrote:
Wed Aug 19, 2020 11:45 am
As an experienced FreeCAD programmer it would be great if you could have a look at realthunder's pending fixes for the Expression engine. That PR seems to be one of the showstoppers for a 0.19 stable.
😂 I’ve been skipping realthunder’s PRs due to them being so huge and daunting.

As you’ve pointed out this specific PR though, I’ll definitely look at this one next 👍

chrisb
Posts: 28938
Joined: Tue Mar 17, 2015 9:14 am

Re: Helping to review pull requests

Post by chrisb » Wed Aug 19, 2020 11:45 pm

ezzieyguywuf wrote:
Wed Aug 19, 2020 12:04 pm
As you’ve pointed out this specific PR though, I’ll definitely look at this one next
Thank you!
A Sketcher Lecture with in-depth information is available in English, auf deutsch, en français, en español.

Post Reply