PR#1148: Backup files policy

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: PR#1148: Backup files policy

Post by plgarcia » Fri Mar 02, 2018 8:45 pm

With the last commit the detection of archives is insensitive to the case for the extension.

triplus
Posts: 8689
Joined: Mon Dec 12, 2011 4:45 pm

Re: PR#1148: Backup files policy

Post by triplus » Sun Mar 04, 2018 12:16 am

plgarcia wrote:
Fri Mar 02, 2018 8:45 pm
With the last commit the detection of archives is insensitive to the case for the extension.
I did a few quick tests and this seem to work OK. All in all i feel your feature proposal is performing reasonably good now. When more users will enable to test and use it. What could happen is some issue or a glitch could emerge you will need to address then. But this is true for a lot of other features in FreeCAD 017 too. Therefore as far as i am concerned i don't see an issue if this feature gets added to FreeCAD 0.17.

plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: PR#1148: Backup files policy

Post by plgarcia » Sun Mar 04, 2018 11:09 am

There is no ambiguity in my mind that if a problem occurs on my code I will put the effort in to correct it!

When I say my code, I embed the whole management of the archives, even if the problem occurs in a line of code I did not personnaly write.

And anybody willing to bring the feature forward can do it I have no suceptibilty for that!

I will write a bit of documentation for end users.
Last edited by plgarcia on Mon Apr 02, 2018 11:17 am, edited 1 time in total.

ezzieyguywuf
Posts: 543
Joined: Tue May 19, 2015 1:11 am

Re: PR#1148: Backup files policy

Post by ezzieyguywuf » Wed Mar 28, 2018 5:16 pm

plgarcia wrote:
Sun Mar 04, 2018 11:09 am
There is no ambiguity in my mind that if a problem occurs on my code I will pout the effort in to correct it!
No doubt you will pout, but you will also need “put”

</bad joke>

abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: PR#1148: Backup files policy

Post by abdullah » Mon Apr 02, 2018 8:58 am

ezzieyguywuf wrote:
Wed Mar 28, 2018 5:16 pm

No doubt you will pout, but you will also need “put”

</bad joke>
I really had to look that one up in a dictionary:
https://en.oxforddictionaries.com/definition/pout
verb
Push one's lips or one's bottom lip forward as an expression of petulant annoyance or in order to make oneself look sexually attractive.
‘she lounged on the steps, pouting’
with object ‘he shrugged and pouted his lips’
Hopefully we are referring to the first part of the "or" :lol:

ezzieyguywuf
Posts: 543
Joined: Tue May 19, 2015 1:11 am

Re: PR#1148: Backup files policy

Post by ezzieyguywuf » Mon Apr 02, 2018 10:31 am

:lol: HAH! I wasn't aware that the second definition was in the dictionary. Typically it is something children do when they're not getting what they want. But undoubtedly women do it as well, for different reasons :-P

(and men)

Image

plgarcia
Posts: 281
Joined: Wed Jun 17, 2015 9:47 pm
Location: Near Paris (France)

Re: PR#1148: Backup files policy

Post by plgarcia » Mon Apr 02, 2018 11:14 am

Don’t you think there are better subjects than typo error to discuss about?
I make my best not to make too many mistakes, but sometimes there are some I do not detect before I send the post. A few minutes ago I did not even know what pout means and I have had also to use the dictionary. I was thinking put of course!
Sorry for that!

Post Reply