PR #1912: Crowdin: fixes pre-0.18 release

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Post Reply
User avatar
Kunda1
Posts: 4803
Joined: Thu Jan 05, 2017 9:03 pm

PR #1912: Crowdin: fixes pre-0.18 release

Post by Kunda1 » Fri Jan 25, 2019 3:39 pm

This PR has been a marathon to get merged because of my lack of ++ skillz

Anyway..the latest issue i'm not sure about: It fails in a test(but not within in the compilation portion of the build).
See https://github.com/FreeCAD/FreeCAD/pull ... -196181639

Any help would be appreciated
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Top
User avatar
Kunda1
Posts: 4803
Joined: Thu Jan 05, 2017 9:03 pm

Re: PR #1912: Crowdin: fixes pre-0.18 release

Post by Kunda1 » Fri Jan 25, 2019 11:48 pm

Calling in re-enforcements...would love to get this stuff in before 0.18 release. :D
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Top
User avatar
Kunda1
Posts: 4803
Joined: Thu Jan 05, 2017 9:03 pm

Re: PR #1912: Crowdin: fixes pre-0.18 release

Post by Kunda1 » Wed Jan 30, 2019 4:00 am

Fixed. This PR is greenlight for merge.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Top
Post Reply

Return to “Pull Requests”