App::Link: the big merge

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
realthunder
Posts: 1026
Joined: Tue Jan 03, 2017 10:55 am

App::Link: the big merge

Post by realthunder » Tue Jul 16, 2019 4:53 am

PR link: https://github.com/FreeCAD/FreeCAD/pull/2350

I have documented the changes through comments in each individual commits, with links to my wiki for more details. For an overview of the Link design, see here, and most of the core changes, here.

PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal

Jee-Bee
Posts: 1919
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: App::Link: the big merge

Post by Jee-Bee » Tue Jul 16, 2019 8:18 am

Good luck with the merge!! i hope is will added to master soon!! 8-)

eugebcn
Posts: 1
Joined: Tue Jul 16, 2019 7:44 pm

Re: App::Link: the big merge

Post by eugebcn » Tue Jul 16, 2019 7:48 pm

This can be a game changer for freecad.
Good luck and thanks for your work.

User avatar
bernd
Posts: 8046
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: App::Link: the big merge

Post by bernd » Tue Jul 16, 2019 7:56 pm

realthunder wrote:
Tue Jul 16, 2019 4:53 am
PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.
on PR with lots of mixed time stamps I rewrite the time stamps ...

https://forum.freecadweb.org/viewtopic.php?f=10&t=36682

user1234
Posts: 166
Joined: Mon Jul 11, 2016 5:08 pm

Re: App::Link: the big merge

Post by user1234 » Tue Jul 16, 2019 10:47 pm

Hello!

fyi: the PR does not compile on Travis CI.

Greetings
user1234

ickby
Posts: 2906
Joined: Wed Oct 05, 2011 7:36 am

Re: App::Link: the big merge

Post by ickby » Wed Jul 17, 2019 8:07 am

oh man, I did not compile freecad for so long that I'm not able to do it anymore :lol: it will take some time till I can poke around with it, but I will definitely have a look!

it is a impressive amount of work and documentation, looking forward to see how it works!

User avatar
kkremitzki
Posts: 1650
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: App::Link: the big merge

Post by kkremitzki » Wed Jul 17, 2019 3:30 pm

I'm looking forward to testing and reviewing this! Glad to see we're finally here.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.

chrisb
Posts: 16895
Joined: Tue Mar 17, 2015 9:14 am

Re: App::Link: the big merge

Post by chrisb » Wed Jul 17, 2019 11:37 pm

kkremitzki wrote:
Wed Jul 17, 2019 3:30 pm
Glad to see we're finally here.
You named it!

User avatar
fosselius
Posts: 340
Joined: Sat Apr 23, 2016 10:03 am

Re: App::Link: the big merge

Post by fosselius » Sun Aug 18, 2019 5:06 am

hmm, most of the thread was removed?

Rene
Posts: 20
Joined: Sun Mar 08, 2015 6:32 pm

Re: App::Link: the big merge

Post by Rene » Sun Aug 18, 2019 8:38 am

fosselius wrote:
Sun Aug 18, 2019 5:06 am
hmm, most of the thread was removed?
In the Open subforum, thread title: App::Link: the big merge
stuff

Post Reply