PR2545 - Refactor and Rename ConsoleObserver

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
ezzieyguywuf
Posts: 656
Joined: Tue May 19, 2015 1:11 am

PR2545 - Refactor and Rename ConsoleObserver

Post by ezzieyguywuf »

Based on a conversation had here, I have begun updating/refactoring some of the code in src/Base/Console.h. My ultimate goal is to minimize/eliminate the need/use of macros in this file. As a first step, I have refactored the ConsoleObserver class.

I think the git commit message does a pretty good job explaining what changed, as well as the motivation. I am opening this thread because I'm not user if this is still the desired way to begin a conversation regarding pull requests (or if I should instead just rely on the commenting features on github itself).
Top
Post Reply

Return to “Pull Requests”