[Open]various Part workbench and main icons

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Post Reply
jmaustpc
Posts: 9535
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

[Open]various Part workbench and main icons

Post by jmaustpc » Thu Jan 30, 2014 7:14 pm

Hi everyone
This is the icons I have posted about here

viewtopic.php?f=10&t=5520&p=44703#p44703
viewtopic.php?f=10&t=5482

Here is the repo, rebased on SF master just now. The branch is at my Bitbucket repo and is called "icon_integration_pull_request", here is a direct link to the branch.

https://bitbucket.org/jmaustpc/my-clone ... ll_request

added icons List
Alignment.svg
Create_Duplicate.svg
Placement.svg
Part_Convert_To_Solid.svg
Part_Create_Compound.svg
Part_Create_Simple_Copy.svg
Part_Reverse_Shape.svg

Jim
Last edited by NormandC on Sat Oct 04, 2014 6:54 pm, edited 1 time in total.
Reason: Added [Open] tag.

jmaustpc
Posts: 9535
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: various Part workbench and main icons

Post by jmaustpc » Sat Feb 15, 2014 10:55 am

Hi all
Was there anything wrong with these icons or the associated code in my branch?

These listed below are the versions I used in my branch, I don't mind if you want to use different version which I posted or something else. I'll make new ones if you have a problem with one or some of them, if you like?

Jim

Added Icons List
Alignment.svg
Image

Create_Duplicate.svg
Image

Placement.svg
Image

Part_Convert_To_Solid.svg
Image

Part_Create_Compound.svg
Image

Part_Create_Simple_Copy.svg
Image

Part_Reverse_Shape.svg
Image

ulrich1a
Posts: 1872
Joined: Sun Jul 07, 2013 12:08 pm

Re: various Part workbench and main icons

Post by ulrich1a » Sat Feb 15, 2014 11:21 am

I did not know about the make compound function in the Part-Workbench until recently, as I used only tools with an icon.
So I really welcome icons for the functions, which do not have one.

Ulrich

jmaustpc
Posts: 9535
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: various Part workbench and main icons

Post by jmaustpc » Sat Feb 15, 2014 11:40 am

ulrich1a wrote:I did not know about the make compound function in the Part-Workbench until recently, as I used only tools with an icon.
So I really welcome icons for the functions, which do not have one.

Ulrich
Another time it can be helpful is if you want to make a custom tool bar. For example if you often find you want to use a small number of functions of a different workbench from within another workbench, you can make a custom tool bar with those functions of the other workbench. e.g add Draft Array to the Part workbench....or add Part "check geometry" to PartDesign workbench or Draft etc.

User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: various Part workbench and main icons

Post by NormandC » Sat Feb 15, 2014 8:19 pm

These icons look good to me, besides I won't criticize if I'm not willing to design alternatives :D

I'm just worried the reverse shape icon looks a lot like the refresh/recompute icon. Also, does this tool work on edges?

jmaustpc
Posts: 9535
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: various Part workbench and main icons

Post by jmaustpc » Tue Feb 25, 2014 8:38 am

normandc wrote: Also, does this tool work on edges?
Hi Norm, I took a while to answer that, I had to experiment.

It used to do so in 0.13, I don't know if it is still doing so in 0.14 or not, because the Part Ruled Surface tool has changed its behaviour. The picture shows what 0.13 used to do, but now 0.14 seems to automatically work out which vertex is the best to link to which other vertex.

This below is what it looks like in 0.13 if one line is reversed and you use Part Ruled Surface
Part_Reverse_Shape_experiments.png
Part_Reverse_Shape_experiments.png (2.08 KiB) Viewed 2097 times
this is the same file as above in 0.14Dev from today, at first it opens the file the same as 0.13 but then if you force a recompute by adjusting a parameter it changes it to what it would do if you had just used Part Ruled Surface in 0.14dev.
Part_Reverse_Shape_experiments1.png
Part_Reverse_Shape_experiments1.png (1.1 KiB) Viewed 2097 times
then if you open the file again in 0.13 it looks as you saved it in 0.14...once again if you recompute it goes back to twisted shape as 0.13 first made.

Jim

Post Reply