pad bug fix for jriegel/dev-assembly

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Post Reply
tmoore
Posts: 8
Joined: Sat Mar 01, 2014 11:44 pm
Location: Bordeaux, France
Contact:

pad bug fix for jriegel/dev-assembly

Post by tmoore » Sun Mar 02, 2014 11:46 am

Hello,
Is this the place for pull requests for the assembly branch? I fixed a bug in the pad sketch up to face operation, which would sometimes fail when the face was parallel to the sketch. The fix is here: https://github.com/timoore/FreeCAD_sf_m ... v-assembly

By way of an introduction, I've been doing real time graphics programming and visual simulation for many years, especially with Open Scene Graph. More recently I've done a lot of work with Open Inventor. My interests in FreeCAD run to carpentry drawing and design of parts made in a home machine shop. Eventually I would be interested in CAM for FreeCAD.

Thanks,
Tim

wmayer
Site Admin
Posts: 14473
Joined: Thu Feb 19, 2009 10:32 am

Re: pad bug fix for jriegel/dev-assembly

Post by wmayer » Sun Mar 02, 2014 12:30 pm

Is this the place for pull requests for the assembly branch?
Thanks for the contribution. I have moved your post to this sub-forum.

Post Reply