Problem copying walls

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Problem copying walls

Post by Roy_043 »

There is an issue if you try to copy walls with Draft_Move. If the 'Move Base' property of the wall is false, the new wall will use the same base as the original. If 'Move Base' is true only the base of the wall is copied.
Possible workaround: use copy-paste.

Code: Select all

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17505 (Git)
Build type: Release
Branch: master
Hash: 755536e9df94d2d39da1468420f1fd333c35da7a
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Dutch/Netherlands (nl_NL)
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Problem copying walls

Post by Roy_043 »

Can someone please check and confirm this. Thanks.
This issue seems related:
https://forum.freecadweb.org/viewtopic.php?f=23&t=39215
Syres
Veteran
Posts: 2900
Joined: Thu Aug 09, 2018 11:14 am

Re: Problem copying walls

Post by Syres »

Roy_043 wrote: Mon Sep 16, 2019 11:55 am Can someone please check and confirm this. Thanks.
This issue seems related:
https://forum.freecadweb.org/viewtopic.php?f=23&t=39215
Using:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18234 (Git)
Build type: Release
Branch: master
Hash: 3af5d97e9b2a60823815f662aba25422c4bc45bb
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

I cannot replicate the bug you describe copying walls, it works as I would expect but I can confirm the bug with the Window move as described in the other thread.
User avatar
bitacovir
Veteran
Posts: 1570
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: Problem copying walls

Post by bitacovir »

Roy_043 wrote: Mon Sep 16, 2019 11:55 am Can someone please check and confirm this. Thanks.
This issue seems related:
https://forum.freecadweb.org/viewtopic.php?f=23&t=39215
Confirmed.

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18213 (Git)
Build type: Release
Branch: master
Hash: 22babc09954ac6fda9135ee71d68550921659b1c
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United States (en_US)
::bitacovir::
==================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

Canal Youtube Grupo Telegram de FreeCAD Español

My personal web site
My GitHub repository
Mini Airflow Tunnel Project
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Problem copying walls

Post by Roy_043 »

Thanks for testing.

@Syres
I have retested with your FreeCAD version, and find the problem persists. Can you check with the attached file? Thanks.

Code: Select all

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18234 (Git)
Build type: Release
Branch: master
Hash: 3af5d97e9b2a60823815f662aba25422c4bc45bb
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Dutch/Netherlands (nl_NL)
Attachments
WallCopy.FCStd
(11.74 KiB) Downloaded 33 times
Syres
Veteran
Posts: 2900
Joined: Thu Aug 09, 2018 11:14 am

Re: Problem copying walls

Post by Syres »

@Roy_043, to be honest when you stated that the fault persisted with build 0.19.18234, I realised this is the second time in 4 days that I've been getting different results to others. Therefore the attached file won't help I'm afraid, the root cause is my config files must be 'polluted'. I went back to version 0.16 (yes a bit drastic) with completely new config files being created and tested the Wall Copy with Draft Move and sure enough it works (the old stuff sometimes is good). Saved that project file and then opened build 0.19.18234 with the project file produced in 0.16 and it upgraded the walls to current IFC etc as expected. When re-attempting the Wall Copy with Draft Move I now get the following in Report View:

Code: Select all

('[Draft.todo.commit] Unexpected error:', <class 'TypeError'>, 'in ', ['Draft.move([FreeCAD.ActiveDocument.Wall],FreeCAD.Vector(14705.305730521744, 6232.246757699953, 1905.2376732576895),copy=True)', 'FreeCAD.ActiveDocument.recompute()'])
Therefore the bug is confirmed, apologies for the noise.
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Problem copying walls

Post by Roy_043 »

I have seen that error message as well, but not in the context of this problem. So we may be talking about two different issues/bugs.
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Problem copying walls

Post by carlopav »

Roy_043 wrote: Mon Aug 12, 2019 7:59 am If the 'Move Base' property of the wall is false, the new wall will use the same base as the original. If 'Move Base' is true only the base of the wall is copied.
I confirm the behaviour:
- If the 'Move Base' property of the wall is false, the new wall will use the same base as the original. -> this is ok i think. It's what i'd expect.
- If 'Move Base' is true only the base of the wall is copied. -> I confirm. Indeed this is not what i was expecting (expecially because the preview shows the wall and not the base).

Code: Select all

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18629 (Git)
Build type: Release
Branch: master
Hash: bb1aec9e60faa8b279306bfebe672b8d4e77351d
Python version: 3.6.7
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Italian/Italy (it_IT)
follow my experiments on BIM modelling for architecture design
User avatar
Roy_043
Veteran
Posts: 8552
Joined: Thu Dec 27, 2018 12:28 pm

Re: Problem copying walls

Post by Roy_043 »

Having two walls share the same base seems undesirable to me. But even if that is the default, there should also be a way to create an independent copy of a wall with its own base.
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Problem copying walls

Post by carlopav »

Yes and no... If a wall is based on "wallTrace" (a sketch with a single line segment), i kinda agree with you. But imagine this workflow:
- you draw the contour of the house with a draft polyline;
- you use it to make the wall
- then you use the same polyline to make the floor slab
- then you copy the first wall to the upper floor
it's not desiderable to make a brand new copy, I swear you'd prefer to have the new wall linked to the same base. Is it? That's more FreeCADish i think. Anyway there are plenty of usecases when instead you want a full indipendent copy, and that could be handled with Ctrl-C Ctrl-V. (Perhaps anyway a completely different tool to make a full indipendent copy could be useful).
follow my experiments on BIM modelling for architecture design
Post Reply