Wall Placement should be necessarily relative to walltrace placement?

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

Interesting scenario @Roy reminded, never thought about this may have cyclic issue, had just did a quick experiment :) :-
  1. Create a Wall, then a Sketch for Window
  2. Map the Sketch to Face 3 of Wall
  3. Move the Wall up say 0.5m, the Sketch follow as expected
  4. Create ArchWindow base on the Sketch
    • Click MapMode of the Sketch of Window, found it no longer attach the Face 3 of Wall
    • 'Face 3 of Wall' now has an opening, become Face10
    • Understandably, if Sketch still attach to original Wall, would it 'move' to the 'revised Face 3' ?, then 'revised' opening position, then new naming of Face, new position of Sketch, new opening .... cyclic ????
  5. Move the Wall to the 'left' say -0.5m, the Sketch of Window & Window do not follow
Maybe later merging of @Realthundar's branch to solve the toponaming problem will help
Screenshot from 2019-12-13 07-19-59.png
Screenshot from 2019-12-13 07-19-59.png (198.26 KiB) Viewed 1154 times
Screenshot from 2019-12-13 07-20-14.png
Screenshot from 2019-12-13 07-20-14.png (189.56 KiB) Viewed 1154 times
Screenshot from 2019-12-13 07-20-37.png
Screenshot from 2019-12-13 07-20-37.png (187.81 KiB) Viewed 1154 times
Screenshot from 2019-12-13 07-21-20.png
Screenshot from 2019-12-13 07-21-20.png (196.87 KiB) Viewed 1154 times
Screenshot from 2019-12-13 07-21-41.png
Screenshot from 2019-12-13 07-21-41.png (201.49 KiB) Viewed 1154 times
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

FC test file attached
Attachments
Test_ Arch Window_ Sketch Map to Wall Problem.fcstd
(20.96 KiB) Downloaded 48 times
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by carlopav »

Can you try to map it to face 1?
follow my experiments on BIM modelling for architecture design
User avatar
Roy_043
Veteran
Posts: 8583
Joined: Thu Dec 27, 2018 12:28 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by Roy_043 »

@carlopav:
You are right: Face1 seems stable. Which is surprising because the other faces, including the opposite major face, are not.
But add some T-junctions and the situation changes dramatically.

In the image the green arrow points to the initial Face1.
The red arrow indicates the current Face1.
Attachments
WallFaceTest.png
WallFaceTest.png (10.55 KiB) Viewed 1131 times
WallFaceTest.FCStd
(22.42 KiB) Downloaded 46 times
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

Yes, if map to Face 1, it won't detach after punching the opening.

Face 1 still remains Face 1.
Screenshot from 2019-12-13 18-09-37.png
Screenshot from 2019-12-13 18-09-37.png (189.42 KiB) Viewed 1123 times
Screenshot from 2019-12-13 18-10-18.png
Screenshot from 2019-12-13 18-10-18.png (194.58 KiB) Viewed 1123 times
Screenshot from 2019-12-13 18-10-49.png
Screenshot from 2019-12-13 18-10-49.png (196.54 KiB) Viewed 1123 times
Screenshot from 2019-12-13 18-11-15.png
Screenshot from 2019-12-13 18-11-15.png (190.71 KiB) Viewed 1123 times
Screenshot from 2019-12-13 18-11-53.png
Screenshot from 2019-12-13 18-11-53.png (188.01 KiB) Viewed 1123 times
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

File attached
Attachments
Test_ Arch Window_ Sketch Map to Wall Problem_ 2.fcstd
(19.82 KiB) Downloaded 42 times
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

yorik wrote: Wed Dec 11, 2019 7:17 pm Ping
https://forum.freecadweb.org/viewtopic. ... 24#p353582

See if you can comment on the finding of this experiment at above post (link above).

In short, I thought when you introduced Window the Host attribute to link to a Wall, then Window Base Sketch can map to a Wall Face without further cyclic problem.

It seem though now attaching Window, with its Base Sketch mapped to a wall, to the wall without complaining by FC, it 'automatically' 'de-map' if the toponame of original Mapmode Reference change.
User avatar
yorik
Founder
Posts: 13665
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by yorik »

These are definitely two different directions.
But, in FreeCAD, we are free, and can take both directions at the same time.

I really like the idea that, for ex, you use Draft Edit on a wall, you see the edit dots under the wall. You don't even have to care where the base wire is. We should be able to do it all: add points, move points, etc... It would all do transparently the conversion between the wall coordinate back to the base wire coordinates.

I never really liked the other direction, that the wall trace should stick to the wall. Never understood why that was needed, actually... I would like to, for ex, be able to select some edges in space and use that to make a wall, even if the wall will be moved later. But as said above, there is no reason why not either, if someone needs it. We can take both directions.
carlopav
Veteran
Posts: 2062
Joined: Mon Dec 31, 2018 1:49 pm
Location: Venice, Italy

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by carlopav »

Thx paullee for the extensive test.
yorik wrote: Fri Dec 13, 2019 8:49 pm I really like the idea that, for ex, you use Draft Edit on a wall, you see the edit dots under the wall.
I can take care of that, at least I think.

But about draft tools, what do you think? Should they just move the wall or should they try to move other object also (base, windows, etc)? Or should we go for an intelligent wall that cares to move its children by himself (so draft tools will just act on the wall object placement) (except for the base that cannot be moved by the wall, but that we perhaps don't want to move anymore)?
follow my experiments on BIM modelling for architecture design
paullee
Veteran
Posts: 5136
Joined: Wed May 04, 2016 3:58 pm

Re: Wall Placement should be necessarily relative to walltrace placement?

Post by paullee »

yorik wrote: Fri Dec 13, 2019 8:49 pm These are definitely two different directions.
Thanks for the views.

But in the test above, what I am not sure I fully understand is the Host property in Window works ...

Scenario 1 : As Expected
- The Window Base Sketch is still parent of Wall after Window's Host is link to Wall (Face 1 of Wall)


Scenario 2 : Not Sure about this
- The Window Base Sketch is found detached, i.e. no longer parent of Wall, after Window's Host is link to Wall
(Original Face 3 of Wall, now become Face 10 after punching the hole)


Scenario 1 : As Expected
Screenshot from 2019-12-14 08-22-40.png
Screenshot from 2019-12-14 08-22-40.png (203.63 KiB) Viewed 1066 times
Scenario 2 : Not Sure about this
Screenshot from 2019-12-14 08-24-37.png
Screenshot from 2019-12-14 08-24-37.png (206.47 KiB) Viewed 1066 times
Post Reply