[Bug] Column Reinforcement

[vances]

• * Install 0.19_pre on macOS Catalina
  * Use Add-On Manager to add BIM
  * Restart FreeCAD
  * Use Add-On Manager to add suggested prerequisites (Dodo, Fasteners, Reinforcements, Reporting, Web Tools)
  * Restart FreeCAD
  * New Document
  * Select BIM Workbench
  * Add Column
  * Select Face
  * Select Column Reinforcement
  * Select OK

Code: Select all

00:48:54  Traceback (most recent call last):
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 657, in clicked
00:48:54      self.accept(button)
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 683, in accept
00:48:54      RebarGroup = makeSingleTieMultipleRebars(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTieMultipleRebars.py", line 125, in makeSingleTieMultipleRebars
00:48:54      SingleTieFourRebarsObject = makeSingleTieFourRebars(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTie.py", line 103, in makeSingleTieFourRebars
00:48:54      facename_for_rebars = getFacenameforRebar(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/Rebarfunc.py", line 543, in getFacenameforRebar
00:48:54      return facename_for_rebars
00:48:54  UnboundLocalError: local variable 'facename_for_rebars' referenced before assignment

[Kunda1]

@vances thanks for the post. Please always add you full About info

CC @amrit3701

[amrit3701]

• * Install 0.19_pre on macOS Catalina
  * Use Add-On Manager to add BIM
  * Restart FreeCAD
  * Use Add-On Manager to add suggested prerequisites (Dodo, Fasteners, Reinforcements, Reporting, Web Tools)
  * Restart FreeCAD
  * New Document
  * Select BIM Workbench
  * Add Column
  * Select Face
  * Select Column Reinforcement
  * Select OK

Code: Select all

00:48:54  Traceback (most recent call last):
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 657, in clicked
00:48:54      self.accept(button)
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 683, in accept
00:48:54      RebarGroup = makeSingleTieMultipleRebars(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTieMultipleRebars.py", line 125, in makeSingleTieMultipleRebars
00:48:54      SingleTieFourRebarsObject = makeSingleTieFourRebars(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTie.py", line 103, in makeSingleTieFourRebars
00:48:54      facename_for_rebars = getFacenameforRebar(
00:48:54    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/Rebarfunc.py", line 543, in getFacenameforRebar
00:48:54      return facename_for_rebars
00:48:54  UnboundLocalError: local variable 'facename_for_rebars' referenced before assignment

Hi @vances,

I just created a column reinforcement using master branch code of Reinforcement repo (https://github.com/amrit3701/FreeCAD-Reinforcement) and on my side everything works fine.

@vances, it would better if you write steps on how I can reproduce your bug. Also, share your fcstd file.

Thanks,

[vances]

@vances thanks for the post. Please always add you full About info

CC @amrit3701

Code: Select all

OS: macOS 10.15
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22261 (Git)
Build type: Release
Branch: master
Hash: 1c432fd6170b7904592a224194e42d3c566707a6
Python version: 3.8.5
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: C/Default (C)

[vances]

• * Install 0.19_pre on macOS Catalina
  * Use Add-On Manager to add BIM
  * Restart FreeCAD
  * Use Add-On Manager to add suggested prerequisites (Dodo, Fasteners, Reinforcements, Reporting, Web Tools)
  * Restart FreeCAD
  * New Document
  * Select BIM Workbench
  * Add Column
  * Select Face
  * Select Column Reinforcement
  * Select OK

@vances, it would better if you write steps on how I can reproduce your bug. Also, share your fcstd file.

I did exactly that above. I started over with a fresh install just to be able to provide exact steps.

[vocx]

Pull request #3827.

[Suraj Dadral]

Hi @vances

The related PR to fix the issue has been merged and you may mark this as solved.

Thanks,

[vances]

The related PR to fix the issue has been merged and you may mark this as solved.

I downloaded and installed 0.19.22411 but got the same thing:

Code: Select all

21:43:42  Traceback (most recent call last):
21:43:42    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 657, in clicked
21:43:42      self.accept(button)
21:43:42    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/MainColumnReinforcement.py", line 683, in accept
21:43:42      RebarGroup = makeSingleTieMultipleRebars(
21:43:42    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTieMultipleRebars.py", line 125, in makeSingleTieMultipleRebars
21:43:42      SingleTieFourRebarsObject = makeSingleTieFourRebars(
21:43:42    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/ColumnReinforcement/SingleTie.py", line 103, in makeSingleTieFourRebars
21:43:42      facename_for_rebars = getFacenameforRebar(
21:43:42    File "/Users/vances/Library/Preferences/FreeCAD/Mod/Reinforcement/Rebarfunc.py", line 543, in getFacenameforRebar
21:43:42      return facename_for_rebars
21:43:42  UnboundLocalError: local variable 'facename_for_rebars' referenced before assignment

OS: macOS 10.15
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.22411 (Git)
Build type: Release
Branch: master
Hash: d4519d5aec15bc08f029da5ed15410a494b57b2c
Python version: 3.8.5
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.4.0
Locale: C/Default (C)

[vocx]

I downloaded and installed 0.19.22411 but got the same thing:

You have to update the Reinforcement addon.

[vances]

You have to update the Reinforcement addon.

No, that's not it. I had updated the addons before upgrading FreeCAD but tried that again now. The Workbench was updated but the Reinforcement addon didn't require updating now.

Later maybe I'll try a clean start again.