PR: Added Length property in the Rebar object #1082

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
User avatar
amrit3701
Posts: 233
Joined: Mon Jun 13, 2016 5:37 pm

PR: Added Length property in the Rebar object #1082

Post by amrit3701 » Sat Nov 11, 2017 8:42 am

Hi everyone,

I have introduced new property to the rebar object i.e. Length. This property calculates the total of the rebar.

PR link: https://github.com/FreeCAD/FreeCAD/pull/1082

Thanks,

User avatar
chakkree
Posts: 288
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Re: PR: Added Length property in the Rebar object #1082

Post by chakkree » Sat Nov 11, 2017 11:47 am

+1 :D

User avatar
yorik
Site Admin
Posts: 11398
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: PR: Added Length property in the Rebar object #1082

Post by yorik » Sun Nov 12, 2017 4:31 pm

Thanks for the PR Amritpal! I just made a small suggestion on github to move the setting of the obj.Length property to inside the execute() function to avoid possible infinite loops.

User avatar
amrit3701
Posts: 233
Joined: Mon Jun 13, 2016 5:37 pm

Re: PR: Added Length property in the Rebar object #1082

Post by amrit3701 » Mon Nov 13, 2017 9:54 am

yorik wrote:
Sun Nov 12, 2017 4:31 pm
Thanks for the PR Amritpal! I just made a small suggestion on github to move the setting of the obj.Length property to inside the execute() function to avoid possible infinite loops.
I replied on PR page (https://github.com/FreeCAD/FreeCAD/pull ... -343865399).

Thanks,

User avatar
chakkree
Posts: 288
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Re: PR: Added Length property in the Rebar object #1082

Post by chakkree » Wed Nov 15, 2017 5:44 am

Rebar's length should take from the BaseWire with fillet's radius(red line).
(Not take from blue line)

Thanks,

RebarLenght.png
RebarLenght.png (552.54 KiB) Viewed 735 times
RebarLenght.FCStd
(46.26 KiB) Downloaded 18 times
------------------
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.12595 (Git)
Build type: Release
Branch: master
Hash: 8c7bb0cd551cf11551ff71d716a16211c6d5e13d
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: English/UnitedStates (en_US)

Post Reply