Page 1 of 1
PR: Added Length property in the Rebar object #1082
Posted: Sat Nov 11, 2017 8:42 am
by amrit3701
Hi everyone,
I have introduced new property to the rebar object i.e. Length. This property calculates the total of the rebar.
PR link:
https://github.com/FreeCAD/FreeCAD/pull/1082
Thanks,
Re: PR: Added Length property in the Rebar object #1082
Posted: Sat Nov 11, 2017 11:47 am
by chakkree
+1
Re: PR: Added Length property in the Rebar object #1082
Posted: Sun Nov 12, 2017 4:31 pm
by yorik
Thanks for the PR Amritpal! I just made a small suggestion on github to move the setting of the obj.Length property to inside the execute() function to avoid possible infinite loops.
Re: PR: Added Length property in the Rebar object #1082
Posted: Mon Nov 13, 2017 9:54 am
by amrit3701
yorik wrote: ↑Sun Nov 12, 2017 4:31 pm
Thanks for the PR Amritpal! I just made a small suggestion on github to move the setting of the obj.Length property to inside the execute() function to avoid possible infinite loops.
I replied on PR page (
https://github.com/FreeCAD/FreeCAD/pull ... -343865399).
Thanks,
Re: PR: Added Length property in the Rebar object #1082
Posted: Wed Nov 15, 2017 5:44 am
by chakkree
Rebar's length should take from the BaseWire with fillet's radius(red line).
(Not take from blue line)
Thanks,
- RebarLenght.png (552.54 KiB) Viewed 1966 times
------------------
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.12595 (Git)
Build type: Release
Branch: master
Hash: 8c7bb0cd551cf11551ff71d716a16211c6d5e13d
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: English/UnitedStates (en_US)