Added color prefs for Sketcher create geometry ops

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
jcb
Posts: 1
Joined: Wed Nov 15, 2017 2:42 pm

Added color prefs for Sketcher create geometry ops

Post by jcb » Thu Nov 16, 2017 5:56 pm

Hi:

Working on light background I had some difficulty viewing sketcher geometry creation operations. The default colors for these is hard coded at present. The cursor crosshair is set to white and the editCurve color is SoMaterial diffuse color default of very light gray (80% white)

I added a minor enhancement with two additional color preferences for the Sketcher: crosshair and editCurve.

Some screenshots to demonstrate:

the default geometry while creating appearance:
sketcher_create_polygon_default_color.png
sketcher_create_polygon_default_color.png (690.16 KiB) Viewed 791 times
the new preferences in default state (which was chosen to be current hardcoded values):
sketcher_color_prefs_default.png
sketcher_color_prefs_default.png (549.94 KiB) Viewed 791 times
altered sketcher colors preferences:
sketcher_color_prefs_alt.png
sketcher_color_prefs_alt.png (555.16 KiB) Viewed 791 times
how the alternate color cursor crosshair appears:
sketcher_create_crosshair_alt_color.png
sketcher_create_crosshair_alt_color.png (659.41 KiB) Viewed 791 times
how the geometry being created appears with alternate color choices:
sketcher_create_polygon_alt_color.png
sketcher_create_polygon_alt_color.png (722.67 KiB) Viewed 791 times
Users with idiosyncratic color preferences might find this useful.

User avatar
dulouie
Posts: 71
Joined: Tue Oct 03, 2017 4:14 pm

Re: Added color prefs for Sketcher create geometry ops

Post by dulouie » Mon Nov 27, 2017 4:54 am

Thanks man, for me it's very useful because i prefere a white background too.
But where i can find the PR or your code?
Last edited by dulouie on Sun Dec 03, 2017 1:44 pm, edited 1 time in total.

User avatar
Kunda1
Posts: 5913
Joined: Thu Jan 05, 2017 9:03 pm

Re: Added color prefs for Sketcher create geometry ops

Post by Kunda1 » Mon Nov 27, 2017 4:59 am

It's in master already git commit c770ce7a343072dd2df
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features

User avatar
dulouie
Posts: 71
Joined: Tue Oct 03, 2017 4:14 pm

Re: Added color prefs for Sketcher create geometry ops

Post by dulouie » Tue Nov 28, 2017 1:50 pm

The black cursor works only for sketcher geometrie tools, not for sketcher constraints tools.

User avatar
Kunda1
Posts: 5913
Joined: Thu Jan 05, 2017 9:03 pm

Re: Added color prefs for Sketcher create geometry ops

Post by Kunda1 » Tue Nov 28, 2017 5:06 pm

dulouie wrote:
Tue Nov 28, 2017 1:50 pm
The black cursor works only for sketcher geometrie tools, not for sketcher constraints tools.
jcb wrote:ping
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features

Post Reply