Sketcher improvements

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
chrisb
Posts: 16915
Joined: Tue Mar 17, 2015 9:14 am

Sketcher improvements

Post by chrisb » Fri May 04, 2018 6:16 pm

Abdullah has implemented phantastic improvements for Sketcher https://github.com/FreeCAD/FreeCAD/pull/1437
- Improved detection of overconstraines
- display where missing constraints have to be applied to reduce degrees of freedom.

Is there something that can be done to get this into master? Abdullah has already rebased once but after some time it got out of sync again.

Here is the corresponding forum discussion: https://forum.freecadweb.org/viewtopic.php?f=10&t=28370

User avatar
yorik
Site Admin
Posts: 11397
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Sketcher improvements

Post by yorik » Fri May 04, 2018 6:58 pm

Looks ok for me, but I prefer to leave the sketcher ones to Werner, too hard for my feeble skills :)

chrisb
Posts: 16915
Joined: Tue Mar 17, 2015 9:14 am

Re: Sketcher improvements

Post by chrisb » Sat May 05, 2018 5:47 am

yorik wrote:
Fri May 04, 2018 6:58 pm
Looks ok for me, but I prefer to leave the sketcher ones to Werner, too hard for my feeble skills :)
No problem, it's done when it's done.

Post Reply