Page 1 of 2

App::Link: the big merge

Posted: Tue Jul 16, 2019 4:53 am
by realthunder
PR link: https://github.com/FreeCAD/FreeCAD/pull/2350

I have documented the changes through comments in each individual commits, with links to my wiki for more details. For an overview of the Link design, see here, and most of the core changes, here.

PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.

Re: App::Link: the big merge

Posted: Tue Jul 16, 2019 8:18 am
by Jee-Bee
Good luck with the merge!! i hope is will added to master soon!! 8-)

Re: App::Link: the big merge

Posted: Tue Jul 16, 2019 7:48 pm
by eugebcn
This can be a game changer for freecad.
Good luck and thanks for your work.

Re: App::Link: the big merge

Posted: Tue Jul 16, 2019 7:56 pm
by bernd
realthunder wrote: Tue Jul 16, 2019 4:53 am PS: I just notice that github reorder my commits in its original time stamp, but I have rebased it multiple times with a refined order. For a more coherent view of the commits, please checkout git commit logs in my branch.
on PR with lots of mixed time stamps I rewrite the time stamps ...

https://forum.freecadweb.org/viewtopic.php?f=10&t=36682

Re: App::Link: the big merge

Posted: Tue Jul 16, 2019 10:47 pm
by user1234
Hello!

fyi: the PR does not compile on Travis CI.

Greetings
user1234

Re: App::Link: the big merge

Posted: Wed Jul 17, 2019 8:07 am
by ickby
oh man, I did not compile freecad for so long that I'm not able to do it anymore :lol: it will take some time till I can poke around with it, but I will definitely have a look!

it is a impressive amount of work and documentation, looking forward to see how it works!

Re: App::Link: the big merge

Posted: Wed Jul 17, 2019 3:30 pm
by kkremitzki
I'm looking forward to testing and reviewing this! Glad to see we're finally here.

Re: App::Link: the big merge

Posted: Wed Jul 17, 2019 11:37 pm
by chrisb
kkremitzki wrote: Wed Jul 17, 2019 3:30 pm Glad to see we're finally here.
You named it!

Re: App::Link: the big merge

Posted: Sun Aug 18, 2019 5:06 am
by fosselius
hmm, most of the thread was removed?

Re: App::Link: the big merge

Posted: Sun Aug 18, 2019 8:38 am
by Rene
fosselius wrote: Sun Aug 18, 2019 5:06 am hmm, most of the thread was removed?
In the Open subforum, thread title: App::Link: the big merge