UI/UX suggestions for Addon Installer

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: UI/UX suggestions for Addon Installer

Post by yorik »

Kunda1 wrote: Thu Aug 02, 2018 2:13 pm mario52 wrote: ↑
02 Aug 2018, 06:19
i add one button execute (edit the macro in FreeCAD and execute)

Great job! What does the community think?
+1

Mario's template is now supported by the addon manager as of git commit 53c2058e0
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: UI/UX suggestions for Addon Installer

Post by Kunda1 »

How do these dimensions looks like to everyone ?
Image
Changed code from:

Code: Select all

        #self.resize(326, 304)
        self.resize(626, 404)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: UI/UX suggestions for Addon Installer

Post by yorik »

+1
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: UI/UX suggestions for Addon Installer

Post by Kunda1 »

yorik wrote: Thu Aug 02, 2018 8:01 pm+1
https://github.com/FreeCAD/FreeCAD/pull/1582

Quick question:
what's the reason why the AddonManager doesn't have a .ui file instead of the dialog being generated from the .py file ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: UI/UX suggestions for Addon Installer

Post by yorik »

Kunda1 wrote: Fri Aug 03, 2018 12:47 pmwhat's the reason why the AddonManager doesn't have a .ui file instead of the dialog being generated from the .py file ?
Because it started as a simple macro, so it was easier to have it all embedded in the same file. Now it could become a separate ui file, though...
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: UI/UX suggestions for Addon Installer

Post by Kunda1 »

yorik wrote: Fri Aug 03, 2018 1:52 pm
Kunda1 wrote: Fri Aug 03, 2018 12:47 pmwhat's the reason why the AddonManager doesn't have a .ui file instead of the dialog being generated from the .py file ?
Because it started as a simple macro, so it was easier to have it all embedded in the same file. Now it could become a separate ui file, though...
Oh, I see! Makes sense. kkremitzki was working on a .ui file.. I wonder if I could use that or even borrow the QGIS .ui (and remove a lot of the bells and whistles).

@yorik BTW, thanks for the PR merge!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: UI/UX suggestions for Addon Installer

Post by Kunda1 »

kkremitzki wrote:ping
Hey man, where is that .ui file you were working on for the Addon Installer. Did you attach it to a post somewhere ?
yorik wrote:ping
How do I render out a .ui file from the python file that runs AddonManager ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: UI/UX suggestions for Addon Installer

Post by Kunda1 »

Revisiting this thread.

Addon Manager is getting a lot more attention lately and the FreeCAD-addon repo along with the FreeCAD-macros repo are both growing. Which means the option list is growing. So there may be merit to revisit the idea of augmenting the UI of the addon manager.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: UI/UX suggestions for Addon Installer

Post by yorik »

We really need to redo it indeed. And integrate a bit more description of the addon (basically we need to fetch the whole readme, I think).
I'll also try to do a little mockup this week...
Kunda1 wrote: Thu Sep 06, 2018 8:31 pm How do I render out a .ui file from the python file that runs AddonManager ?
Showing an ui file is easy:

Code: Select all

import FreeCADGui
mydialog = FreeCADGui.PySideUic.loadUi("/path/to/my/dialog.ui")
mydialog.show()
But the real work is to write and tie the code behind each button and control... In the case of the Addon manager, most of it is there already, but it would still need some work to adapt.
Post Reply