Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.
I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
kkremitzki wrote:
Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.
I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.
I'm not a cmake guru but I think the whole block I highlighted in my previous post can be deleted. After your last change I think your copying nothing from one place to another? Compiling now to check.
kkremitzki wrote:
Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.
I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.
I'm not a cmake guru but I think the whole block I highlighted in my previous post can be deleted. After your last change I think your copying nothing from one place to another? Compiling now to check.
Testing here as well, I figured that change was the minimum to not have a failed build, but I'm even less than "not a cmake guru" myself.
Edit: Just finished compiling and it looks good, I removed that whole block and pushed the changes again.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
kkremitzki wrote:Testing here as well, I figured that change was the minimum to not have a failed build, but I'm even less than "not a cmake guru" myself.
Edit: Just finished compiling and it looks good, I removed that whole block and pushed the changes again.
I did the same locally, everything is good, all unit tests passed from the gui. I vote for a pull request.
You guys should make a feature announcement. @yorik I just noticed the dxf stuff, great! I think this should greatly help the users! No more trouble getting the addon macro as raw etc. Congrats!
yorik wrote:Updating a macro should just delete the old files, normally...
I mean if a user has "Allow FreeCAD to automatically download and update DXF libraries" in Import/Export DXF prefs and installs with the Addons installer, then there are two copies. One in the Mod folder and one in the Macros folder.
I hadn't followed on your progress until I saw this was merged. Great work guys!
It even recognized workbenches I installed manually by Git.
Just wondering, was the UI redesign with preview pane by kkremitzki abandoned? My Addon manager window still looks like the one from the first post in this topic.