The help and development forum of FreeCAD
https://forum.freecad.org/
The icons you have done are just awesomeagryson wrote:I've just submitted a pull request to your branch with the three icons shown below. I've built and tested. The toggle behaviour doesn't seem to work, was that on another branch?
spritesheet.png
No problem, added to my list. I could use degree with an add/minus symbol (even if you don't use minus for now, the icon can be ready for you)abdullah wrote:I have one more tool, this just increases the degree of the bspline by one on each click
No problem, my philosophy is that it's better to deliver something and iterate than to wait until you have it "perfect". Just as long as it's somewhere on someone's todo list. Keep delivering code!abdullah wrote:a) in the sketcher we have quite an abstraction for adding commands, making the toggability not straight-forward.
b) As for now, I am concentrating my efforts on providing functionality over design (probably totally the wrong place to say this words) so that people can get going with B-Splines in FreeCAD, leaving design enhancements for later on.
c) It is quite obvious from the viewer whether the layers are set or not, so the user should not be confused (although I do understand that better UX/UI is indeed better).
Thanks a lot Alex. They look really great. It is inspiring for me not to have those X (icon not found) around. I have the icons integrated in my local branch. Not yet in my GitHub branch. I have cherry picked them. The reason is that I am in the middle of a development with local commits that I want to squash with future commits. Cherry picking + rebasing allows me to put your commits before my already committed (locally) code and then continue with the code. Yes, I am complicated, I know, I have to live with myselfagryson wrote:There, you have a pull request with everything. I filled in the .qrc but I see there's a .qrc.depends...I didn't touch that but don't know if I was supposed to. Could you double check? It builds fine despite that.
Wow, I've been doing it manually like some kind of neanderthal!abdullah wrote:EDIT: You do not need to fill the .qrc file manually. There is an script in /Resources, just one dir up of icons, with a script UpdateResources (pick the bat or the sh depending on whether you are using Windows or Linux). It autofills it and it does it in the "right order" (simplifies watching differences between commits).
You can also reorder commits in an interactive rebase, no need to cherry pick, but hey, everyone has their workflow! Let me know if any other icons are needed.abdullah wrote:Cherry picking + rebasing allows me to put your commits before my already committed (locally) code and then continue with the code. Yes, I am complicated, I know, I have to live with myself
Definitely! for low amount of commits I usually cherry-pick into my branch for another person branch (yes, this is just me being me). Within my branch I reorder of course using git rebase -i.agryson wrote:You can also reorder commits in an interactive rebase, no need to cherry pick, but hey, everyone has their workflow! Let me know if any other icons are needed.
It would be great if you could provide me with two additional icons. One for increasing a knot multiplicity and another one for decreasing a knot multiplicity. The increment/decrement is "by one unit" for each time the command is executed.agryson wrote:There, you have a pull request with everything. I filled in the .qrc but I see there's a .qrc.depends...I didn't touch that but don't know if I was supposed to. Could you double check? It builds fine despite that.
), but I guess that because of the similarity you would best do both at the same time 