Assembly Workbench icons aligned to guidelines

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
agryson
Posts: 453
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Assembly Workbench icons aligned to guidelines

Post by agryson » Sun Mar 19, 2017 2:36 pm

Last real workbench, just the core icons left!

Old on left, new on right, on light, mid-grey and dark backgrounds at 16, 24, 32 and 64px respectively.

Question: anyone know where the main workbench icon for assembly is? I can't find it in the usual Gui/Resources/icons
spritesheet_main.png
spritesheet_main.png (289.54 KiB) Viewed 999 times
spritesheet_constraints.png
spritesheet_constraints.png (456.69 KiB) Viewed 999 times
spritesheet_actions.png
spritesheet_actions.png (23.99 KiB) Viewed 999 times
Feedback welcome.

User avatar
saso
Posts: 1310
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Assembly Workbench icons aligned to guidelines

Post by saso » Sun Mar 19, 2017 2:44 pm

You are moving mountains Alex! But I guess that's the way things go with FreeCAD :)

User avatar
DeepSOIC
Posts: 6966
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Assembly Workbench icons aligned to guidelines

Post by DeepSOIC » Sun Mar 19, 2017 4:49 pm

agryson wrote:Question: anyone know where the main workbench icon for assembly is? I can't find it in the usual Gui/Resources/icons
It is hard-coded into InitGui.py as XPM string.

User avatar
agryson
Posts: 453
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Assembly Workbench icons aligned to guidelines

Post by agryson » Sun Mar 19, 2017 4:51 pm

DeepSOIC wrote:It is hard-coded into InitGui.py as XPM string.
Thanks, I imagine that's just during dev, a main icon will eventually be required (to show up in settings etc.), no?

User avatar
DeepSOIC
Posts: 6966
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Assembly Workbench icons aligned to guidelines

Post by DeepSOIC » Sun Mar 19, 2017 4:55 pm

agryson wrote:, a main icon will eventually be required (to show up in settings etc.), no?
Yep! Would be great if you make one.

triplus
Posts: 8677
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly Workbench icons aligned to guidelines

Post by triplus » Sun Mar 19, 2017 6:49 pm

I don't know why i left out Assembly workbench when i did the conversion from XPM to SVG workbench icons. Likely one of the following reasons:
  • It's disabled by default and not usable.
  • It wasn't in compilable state and i couldn't easily test the changes.
  • Or both.
P.S. If there is desire i can still do that in the following week.

User avatar
agryson
Posts: 453
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Assembly Workbench icons aligned to guidelines

Post by agryson » Sun Mar 19, 2017 7:03 pm

triplus wrote:I don't know why i left out Assembly workbench when i did the conversion from XPM to SVG workbench icons. Likely one of the following reasons:
  • It's disabled by default and not usable.
  • It wasn't in compilable state and i couldn't easily test the changes.
  • Or both.
P.S. If there is desire i can still do that in the following week.
Well it's at the top of InitGui, I could easily whip something up since it seems very similar to the tree icons that I've already done, just need the page at top right. I'll try to have that done today or tomorrow to make it part of the pull request. If I have difficulties, I might ping you @triplus

triplus
Posts: 8677
Joined: Mon Dec 12, 2011 4:45 pm

Re: Assembly Workbench icons aligned to guidelines

Post by triplus » Sun Mar 19, 2017 7:17 pm

You can look for reference here:

https://github.com/FreeCAD/FreeCAD/pull/102

You'll need to edit InitGui.py and CMakeLists.txt file. Adding the icon to resources (.qrc) isn't technically needed for workbench icon purposes ATM. But i guess it doesn’t hurt to have the icon available from the resources.

User avatar
agryson
Posts: 453
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Assembly Workbench icons aligned to guidelines

Post by agryson » Sun Mar 19, 2017 8:02 pm

triplus wrote:You'll need to edit InitGui.py and CMakeLists.txt file.
Thanks for the heads up, my build was complaining of a missing icon - I had edited InitGui.py but had missed the CMakeLists.txt.

I should be able to post something in the next hour or so.

User avatar
agryson
Posts: 453
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Assembly Workbench icons aligned to guidelines

Post by agryson » Sun Mar 19, 2017 9:16 pm

Done.
Thanks for the tip on implementation @triplus

This can now be in the pull request. (tested sucessfully on local)
AssemblyWorkbench.svg
(29.48 KiB) Downloaded 62 times

Post Reply