Yes, I know but it was effortless to finish the full set and share it in case it will be needed in the future
triplus wrote: ↑Mon Aug 21, 2017 11:33 pm
Therefore i feel we should just do that. As for the PR i guess two options. Wait for @ickby to finish holiday or i guess go for it. If you need any help just ask (i will have time tomorrow). That is for Part icon. As for the Body icon i don't know. There is one already but the proposed one got high level of consensus.
I prefer then to wait for more concise indications. Thank you for the help, actually what I need is just pointing out the route (path) inside Master to place the .svg file and with what specific name you want/need it. If overwritting a preexisting one then is easier but if a new icon then I need this help.
pablogil wrote: ↑Mon Aug 21, 2017 11:39 pm
what I need is just pointing out the route (path) inside Master to place the .svg file and with what specific name you want/need it.
See this commit in PR 916. ickby had already added your old one.
Maybe best to wait for the PR to get merged and after just to replace the Part (potentially Body) icon(s).
P.S. BUT what about Group feature icon. What does it do and did we somehow overlook it was intended to be a part of this icon challenge? I guess in a way a good thing as two ongoing efforts are usually a bit harder to achieve compared to single ones.
triplus wrote: ↑Mon Aug 21, 2017 11:47 pm
BUT what about Group feature icon.
That PR adds a new global toolbar for the "Create Part" command and he also added the command for creating a standard group (a folder in the tree) to that toolbar. This is the icon he used: Group.svg
I see that useful right-click Group feature one can add to Tree view. I guess some could argue why not (in addition) Draft VisGroup. Maybe because features like Module would fit better on such toolbar in the future.
Anyway i am happy consensus was build around Part icon. To me it i guess does make sense to try out new Body icon and see how it goes. As for Assembly icon. Too bad no new features for that in FreeCAD 0.17. But the icon looks good and that in the end is something. As for the Group icon i guess proposals welcomed.
pablogil wrote: ↑Mon Aug 21, 2017 11:39 pm
Thank you for the help, actually what I need is just pointing out the route (path) inside Master to place the .svg file and with what specific name you want/need it.
Create a pull request and in it add description please wait until PR 916 is merged: