Small enhancements to Attacher UX

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

Post Reply
peterl94
Posts: 999
Joined: Thu May 23, 2013 7:31 pm
Location: United States

Small enhancements to Attacher UX

Post by peterl94 » Fri Sep 01, 2017 11:12 pm

There is a few small enhancements I would like to make to Attacher.

1. Make Map Reversed and Map Path Parameter readonly when they don't apply (e.g. when mode is deactivated).
2. Make "Extra Placement" group box in attachment editor disabled when object is not attached.
3. Make a special property and property editor for MapMode that would just have a label (instead of a dropdown) for the mode and have a "..." button to open the task dialog. The reasoning for this is that there is only a few modes out of the long list that can be set with the same references, so I don't think it would be a disadvantage to always have to use the task dialog since you have to most of the time anyway.

I would appreciate your feedback.

User avatar
DeepSOIC
Posts: 6949
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Small enhancements to Attacher UX

Post by DeepSOIC » Fri Sep 01, 2017 11:33 pm

+1+1+1 :mrgreen:

1 + 2 + graying out Placement have already been done in pre-extension era of attachment. Something is broken now :x ...
3 is harder....

peterl94
Posts: 999
Joined: Thu May 23, 2013 7:31 pm
Location: United States

Re: Small enhancements to Attacher UX

Post by peterl94 » Mon Sep 04, 2017 3:40 am

Hey DeepSOIC,

Do I have the modes correct for MapPathParameter? I copied them form AttachEngine3D::calculateAttachedPlacement.

Code: Select all

+            bool modeIsPointOnCurve = mmode == mmNormalToPath ||
+                mmode == mmFrenetNB || mmode == mmFrenetTN || mmode == mmFrenetTB ||
+                mmode == mmRevolutionSection || mmode == mmConcentric;
+
+            this->MapPathParameter.setReadOnly(!bAttached || !modeIsPointOnCurve);

User avatar
DeepSOIC
Posts: 6949
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Small enhancements to Attacher UX

Post by DeepSOIC » Mon Sep 04, 2017 12:02 pm

peterl94 wrote:
Mon Sep 04, 2017 3:40 am
Do I have the modes correct for MapPathParameter?
seems correct. But these modes can take (Edge) and (Edge+Vertex) and (Vertex+Edge), and only when only (Edge), the path parameter is active.

Post Reply