Custom properties look bad on dark themes

[adrianinsaval]

Hi, custom properties look bad and are hard to read whe using a dark theme. I'm not sure where in the code this can be adressed.

Anotación 2019-11-07 194817.png (3.39 KiB) Viewed 1802 times

Steps to reproduce:
Click on any object -> right clik in property tab -> show all-> right clik in a property -> add property

Also, the option to add property is not shown until you tick the 'show all' option, is this the intended behavior?

Also a new thing: dynamic properties, addable through property editor.

OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18640 (Git)
Build type: Release
Branch: master
Hash: 2251f53eb5af097cbb4b879af89575132660e541
Python version: 3.7.3
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Spanish/Paraguay (es_PY)

[DeepSOIC]

Also, the option to add property is not shown until you tick the 'show all' option, is this the intended behavior?

I don't know. Possibly.

[adrianinsaval]

Also, the option to add property is not shown until you tick the 'show all' option, is this the intended behavior?

I don't know. Possibly.

sorry, since you posted it I thougth you developed it but it seems it was realthunder?

ping

[realthunder]

Hi, custom properties look bad and are hard to read whe using a dark theme. I'm not sure where in the code this can be adressed.

I am not sure how to solve this either. Anyone familiar with Qt stylesheet? BTW, the yellow background is only shown if you enable 'Show all', just to give the user a visual feedback on which property is dynamic and can be removed. Removing a dynamic property may have consequences, so I consider this as advanced operation, and therefore hidden unless you 'Show all'. For the same reason, you are not supposed to turn on 'Show all' all the time.

[realthunder]

I've submit a PR to force black text color when showing yellow background.

[adrianinsaval]

I've submit a PR to force black text color when showing yellow background.

Thanks!

[pablogil]

I'm the Qt stylesheets developer, it would be easy to fix if this custom property gets an ID so that I can access it via Qt styling but as I guess, the yellowish background color is hardcoded.
It's necessary that it is applied this ID (or class) to the custom property element so that I can create the correct style inside the stylesheet (text color and background, both following the global style, of course).

Cheers

[realthunder]

I'm the Qt stylesheets developer, it would be easy to fix if this custom property gets an ID so that I can access it via Qt styling but as I guess, the yellowish background color is hardcoded.
It's necessary that it is applied this ID (or class) to the custom property element so that I can create the correct style inside the stylesheet (text color and background, both following the global style, of course).

Cheers

How to set the ID for a property item? I know it's easy to set name for any QObject, but how to do that for an item within a QTreeView? Or, is there any way to define some named color in the stylesheet, so I can somehow retrieve it programmatically?

[vocx]

How to set the ID for a property item? I know it's easy to set name for any QObject, but how to do that for an item within a QTreeView? Or, is there any way to define some named color in the stylesheet, so I can somehow retrieve it programmatically?

https://doc.qt.io/qt-5/stylesheet-examples.html

It's probably something similar to that. Qt has a ton of options.

See also the other thread Blue on Black.

[pablogil]

How to set the ID for a property item? I know it's easy to set name for any QObject, but how to do that for an item within a QTreeView? Or, is there any way to define some named color in the stylesheet, so I can somehow retrieve it programmatically?

https://doc.qt.io/qt-5/stylesheet-examples.html

It's probably something similar to that. Qt has a ton of options.

See also the other thread Blue on Black.

Yes, the two threads may be solved with the same objectName Qt property that me as designer don't know how to add it into the code. If any of you add them and give me the names you have used I can add the styles inside the stylesheets...