Dark theme is almost there

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

Post Reply
leoheck
Posts: 472
Joined: Tue Mar 13, 2018 5:56 pm

Dark theme is almost there

Post by leoheck » Sat Apr 18, 2020 8:54 pm

Hello there, I use dark OS theme regularly and Freecad needs some attention to fix some small issues.
I don't know if Freecad can address all of the issues, but believe it can at least most of them.

I am using Ubuntu 20.04 and Freecad 0.18.4

Here are the screenshots using 3 different OS themes

1. The original Gnome Adwaita theme
Screenshot-20200418172739-1556x861.png
Screenshot-20200418172739-1556x861.png (251.32 KiB) Viewed 584 times
2. The original Gnome Adwaita-dark theme
Screenshot-20200418172814-1556x861.png
Screenshot-20200418172814-1556x861.png (172.7 KiB) Viewed 584 times
Screenshot-20200418174247-534x669.png
Screenshot-20200418174247-534x669.png (39.71 KiB) Viewed 584 times
Screenshot-20200418174407-702x444.png
Screenshot-20200418174407-702x444.png (45.93 KiB) Viewed 584 times
3. The original Ubuntu Yaru-dark theme (that I use)
Screenshot-20200418172903-1556x861.png
Screenshot-20200418172903-1556x861.png (222.82 KiB) Viewed 584 times

So, here it is the list with the minor details that could be improved because they don't fit the dark side.
1. The "Active Body" style.
2. The black (normal) text color in the Python view and Report view. The Blue and Red fonts do not use a good HUE for dark, but they are kind of readable.
3. Disabled items in menus have the same issue as in #2
4. The background gradient in the Tasks panel should not have white too. I think Freecad does not need the gradient here, even in light themes, since it is only present in this panel.
5. The separator in the toolbar could be less dark.


Extra, (found it now) this Accessories > Icon themes, has this b'FreeCAD-default\n' text with these control characters that should not be displayed.
I think I can't add more screenshots.

leoheck
Posts: 472
Joined: Tue Mar 13, 2018 5:56 pm

Re: Dark theme is almost there

Post by leoheck » Sat Apr 18, 2020 10:31 pm

This is a general improvement

The add-on manager has this remove icon. Does it really necessary? Other buttons don't have any icon. Also, if it is necessary I believe it is bigger than normal.
Screenshot-20200418192823-637x548.png
Screenshot-20200418192823-637x548.png (49.11 KiB) Viewed 568 times

leoheck
Posts: 472
Joined: Tue Mar 13, 2018 5:56 pm

Re: Dark theme is almost there

Post by leoheck » Sun Apr 19, 2020 5:34 am

Also, the Start page has this dominant white background that is not good when using dark themes, especially if working at night.
Attachments
Screenshot-20200419023140-1108x543.png
Screenshot-20200419023140-1108x543.png (56.76 KiB) Viewed 549 times

User avatar
Kunda1
Posts: 8386
Joined: Thu Jan 05, 2017 9:03 pm

Re: Dark theme is almost there

Post by Kunda1 » Tue Apr 21, 2020 6:38 pm

Mod edit: Moved to UI/UX subforum
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features

adrianinsaval
Posts: 344
Joined: Thu Apr 05, 2018 5:15 pm

Re: Dark theme is almost there

Post by adrianinsaval » Tue Apr 21, 2020 9:59 pm

leoheck wrote:
Sat Apr 18, 2020 8:54 pm
So, here it is the list with the minor details that could be improved because they don't fit the dark side.
1. The "Active Body" style.
2. The black (normal) text color in the Python view and Report view. The Blue and Red fonts do not use a good HUE for dark, but they are kind of readable.
4. The background gradient in the Tasks panel should not have white too. I think Freecad does not need the gradient here, even in light themes, since it is only present in this panel.
5. The separator in the toolbar could be less dark.


Extra, (found it now) this Accessories > Icon themes, has this b'FreeCAD-default\n' text with these control characters that should not be displayed.
I think I can't add more screenshots.
1 and 2 can be customized by the user, I doubt this can be easily adressed
+1 to getting rid of the gradient in task panel
5 (and 4 to a lesser extent) probably has more to do with the theme you are using and how it is interpreted by qt rather than with freecad itself, I believe you are using a GTK theme and qt's translation of it isn't perfect
Icon themes thing is an external addon and should be reported to the developer of the addon

I think some of your concerns are not present in FreeCAD's included themes, try setting FreeCAD to use one of theme if it's really bothering you

triplus
Posts: 9475
Joined: Mon Dec 12, 2011 4:45 pm

Re: Dark theme is almost there

Post by triplus » Wed Apr 22, 2020 10:29 am

AFAIK it is possible to apply a stylesheet through the .qss file for Start workbench. It's just that nobody has done it yet, added it. As for the rest, like colors of text, that is customizable in Preferences.

Jee-Bee
Posts: 2128
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Dark theme is almost there

Post by Jee-Bee » Wed Apr 22, 2020 11:22 am

same as work background for some reason everbody stick with ugly default blueish background...

leoheck
Posts: 472
Joined: Tue Mar 13, 2018 5:56 pm

Re: Dark theme is almost there

Post by leoheck » Wed Apr 22, 2020 1:50 pm

same as work background for some reason everbody stick with ugly default blueish background...
Totally agree on that. I was trying to get the issues reported first haha.

adrianinsaval wrote:
Tue Apr 21, 2020 9:59 pm
1 and 2 can be customized by the user, I doubt this can be easily adressed
Having in-app themes/icons is a good way to workaround something but after that, some effort should be put in improving UI in a proper way, I guess. I found this, maybe it can help to detect the user's OS theme.
https://stackoverflow.com/questions/358 ... dark-theme

Post Reply