[Solved] Non-standard coloured dimensions?

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

[Solved] Non-standard coloured dimensions?

Post by Syres »

With the same FreeCAD file, user.cfg and system.cfg for both tests, using :

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14575 (Git)
Build type: Release
Branch: master
Hash: a624fee2c27bbbb869df6a8ce40438953a282a8c
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedKingdom (en_GB)
018_14575.jpg
018_14575.jpg (6.71 KiB) Viewed 1537 times
the dimensions when changed colour were both changed for the text and the arrows but using:

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15860 (Git)
Build type: Release
Branch: master
Hash: 3b708c7f84b0425076b520e1d95627b20fd75fe0
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedKingdom (en_GB)

only the arrows change colour. Was this due to a request to comply with a particular standard, is there another setting I need to change in the most recent build or have I stumbled upon a regression?
018_15860.jpg
018_15860.jpg (6.73 KiB) Viewed 1537 times
Last edited by Syres on Wed Feb 20, 2019 9:14 am, edited 1 time in total.
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Non-standard coloured dimensions?

Post by wandererfan »

Syres wrote: Wed Feb 13, 2019 4:34 pm ...have I stumbled upon a regression?
I believe so. Probably occurred when tolerances were added.

Thanks for catching this. PR on the way.
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Non-standard coloured dimensions?

Post by wandererfan »

Should be fixed by git commit 21353779d9f
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: Non-standard coloured dimensions?

Post by Syres »

wandererfan wrote: Fri Feb 15, 2019 12:34 am Should be fixed by git commit 21353779d9f
Thanks @wandererfan, sorry for the delay confirming all is sorted, I've only just had chance to test it.
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: Non-standard coloured dimensions?

Post by Syres »

wandererfan wrote: Fri Feb 15, 2019 12:34 am Should be fixed by git commit 21353779d9f
It would appear there's been a regression on the same issue but this time the text is the correct colour and it's the dimension line and arrows that are black. The last correct working build I have is:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17803 (Git)
Build type: Release
Branch: master
Hash: 89961a33d46063a43e9fb5b0308ca95d559eca94
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

from around 20th August.

All builds since including the latest I have, produce a black dimension line/arrows with correctly coloured text:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18284 (Git)
Build type: Release
Branch: master
Hash: cd8f0e0960d048032b6967edb9e8952541a5eb6c
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Non-standard coloured dimensions?

Post by wandererfan »

Syres wrote: Wed Sep 25, 2019 4:12 pm It would appear there's been a regression on the same issue but this time the text is the correct colour and it's the dimension line and arrows that are black. The last correct working build I have is:
Things might be very different after this change.
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: Non-standard coloured dimensions?

Post by Syres »

wandererfan wrote: Wed Sep 25, 2019 4:39 pm Things might be very different after this change.
Sorry to say but while the new functionality looks good the colour bug is still reproducible using:

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.18351 (Git)
Build type: Release
Branch: master
Hash: fb7a03a04d04e770305f96a31b608d6951d927c8
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)
User avatar
wandererfan
Veteran
Posts: 6326
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: Non-standard coloured dimensions?

Post by wandererfan »

Syres wrote: Sat Sep 28, 2019 6:18 pm Sorry to say but while the new functionality looks good the colour bug is still reproducible using:
Should be (mostly) fixed by git commit d7dabeb885 and git commit 12335c7d52.

Still an issue where the dimension text changes color while being dragged. The colour is corrected when the cursor leaves the dim text area.
Syres
Veteran
Posts: 2902
Joined: Thu Aug 09, 2018 11:14 am

Re: Non-standard coloured dimensions?

Post by Syres »

wandererfan wrote: Mon Sep 30, 2019 11:30 am Should be (mostly) fixed
Thanks for the swift fix.
Post Reply