[fixed] missing Arch view warning/error message

[uwestoehr]

Arch view misses a clear warning/error message:

- open the attached testfile:

TD-test.FCStd

testfile

(138.06 KiB) Downloaded 20 times

- select e.g. the Left projection view
- now insert an ArchView

result: since there is no Arch object of course it cannot be added. Nevertheless there should be a clear error or warning message e.g. that there is no Arch object selected and that it can therefore not be inserted. Instead I only get this error in the report view window:

Code: Select all

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\FreeCAD-build\Mod\Arch\ArchSectionPlane.py", line 315, in getSVG
    objs, cutplane, onlySolids, clip, direction = getSectionData(source)
  File "D:\FreeCAD-build\Mod\Arch\ArchSectionPlane.py", line 132, in getSectionData
    p = FreeCAD.Placement(source.Placement)
<class 'AttributeError'>: 'TechDraw.DrawProjGroupItem' object has no attribute 'Placement'
7.67e-07 <App> Document.cpp(3440): Failed to recompute TD_test#ArchView: 'TechDraw.DrawProjGroupItem' object has no attribute 'Placement'
Recompute failed! Please check report view.

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19443 (Git)
Build type: Release
Branch: master
Hash: 74680b8a15ad37e53eee0d341e95cd32631d88a3
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)

[wandererfan]

- open the attached testfile: TD-test.FCStd
- select e.g. the Left projection view
- now insert an ArchView

Code: Select all

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\FreeCAD-build\Mod\Arch\ArchSectionPlane.py", line 315, in getSVG
    objs, cutplane, onlySolids, clip, direction = getSectionData(source)
  File "D:\FreeCAD-build\Mod\Arch\ArchSectionPlane.py", line 132, in getSectionData
    p = FreeCAD.Placement(source.Placement)
<class 'AttributeError'>: 'TechDraw.DrawProjGroupItem' object has no attribute 'Placement'
7.67e-07 <App> Document.cpp(3440): Failed to recompute TD_test#ArchView: 'TechDraw.DrawProjGroupItem' object has no attribute 'Placement'
Recompute failed! Please check report view.

OS: Windows 7 SP 1 (6.1)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.19443 (Git)
Build type: Release
Branch: master
Hash: 74680b8a15ad37e53eee0d341e95cd32631d88a3
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Germany (de_DE)

This will have to be fixed in ArchSectionPlane. Doesn't look like it knows how to handle a ProjectionGroup.

Do Architects use the traditional mechanical drawing multiview?

[uwestoehr]

This will have to be fixed in ArchSectionPlane. Doesn't look like it knows how to handle a ProjectionGroup.
Do Architects use the traditional mechanical drawing multiview?

I am not an architect. Maybe Yorik or Bernd can help us here?

I am currently updating the TechDraw Wiki pages and therefore just try out the different tools.
If e.g. an Arch View in a projection group is not sensible, I think TechDraw should then disable the menu and toolbar button to insert an Arch view there.

.

.

[wandererfan]

result: since there is no Arch object of course it cannot be added. Nevertheless there should be a clear error or warning message

Should be fixed by git commit d6f9a6ddff.

[vocx]

...
If e.g. an Arch View in a projection group is not sensible,...

TechDraw_ArchView (old TechDraw_NewArch) only works on Arch_SectionPlane objects. You have to create this object first, select it in the 3D view, and then use TechDraw_ArchView. It is not meant to be used with the other "views" created with TechDraw, certainly not projection views.

[uwestoehr]

Should be fixed by git commit d6f9a6ddff.

Many thanks. However, since this commit I get also for the example file of this thread this error:

Code: Select all

Reading failed from embedded file: PartShape8.brp (133002 bytes, 49082 bytes compressed)

[wandererfan]

Many thanks. However, since this commit I get also for the example file of this thread this error:

Code: Select all

Reading failed from embedded file: PartShape8.brp (133002 bytes, 49082 bytes compressed)

Do you get this message with any other files? PartShape8.brp would be one of the files inside the FCStd I think. The only files we read are the Template and the hatch files.

[uwestoehr]

Do you get this message with any other files? PartShape8.brp would be one of the files inside the FCStd I think.

No, only with some files. They all have in common that they have TD pages inside. However, not all files having TD pages are affected. They have however in common that they have RichText annotations.