Freecad included the named patch crashes with a segmentation fault while opening my document.
I located the following introducing the regression:
Committer WandererFan<WandererFan@gmail.com>
Author donovaly<uwestoehr@lyx.org>
Author date 26.03.20 01:40
Parent [TD] Detail view - add missing update
Obviously the calling order of two functions is changed. I created the following patch and was able to open my document again:
src/Mod/TechDraw/App/DrawProjGroup.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Mod/TechDraw/App/DrawProjGroup.cpp b/src/Mod/TechDraw/App/DrawProjGroup.cpp
index c63dd05d3..5832df07f 100644
--- a/src/Mod/TechDraw/App/DrawProjGroup.cpp
+++ b/src/Mod/TechDraw/App/DrawProjGroup.cpp
@@ -425,8 +425,8 @@ App::DocumentObject * DrawProjGroup::addProjection(const char *viewProjType)
}
if (view != nullptr) { //coverity CID 151722
// the label must be set before the view is added
- view->Label.setValue(viewProjType);
addView(view); //from DrawViewCollection
+ view->Label.setValue(viewProjType);
view->Source.setValues(Source.getValues());
// the Scale is already set by DrawView
view->Type.setValue(viewProjType);
Crash after commit "[TD] Detail view - add missing update"
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
- wandererfan
- Veteran
- Posts: 6326
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: Crash after commit "[TD] Detail view - add missing update"
Here is my testfile.
- Attachments
-
- Korpus.FCStd
- (262.83 KiB) Downloaded 16 times
- wandererfan
- Veteran
- Posts: 6326
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: Crash after commit "[TD] Detail view - add missing update"
Thanks for the file. The crash should be fixed by git commit 0f477df6ed
Re: Crash after commit "[TD] Detail view - add missing update"
Thanks for the fix. I will test it.