importIFC module refactor

[bernd]

last change on the loop inside loop was made here ... git commit 2d1f6ab1

[bernd]

git commit efba264

I made a lot of comments and prints. I would leave it ATM. I will keep an eye on all these color import. Since I use IFC import quite a lot ATM even from different resources this will improve by the time being.

[yorik]

Definitely, there is a lot of room for improvement.

I really want to find a better way to transfer shapes from ifcopenshell to FreeCAD too, that doesn't pass through strings. I was thinking of pythonOCC, but it's really a PITA to compile and would be a very problematic dependency. Maybe actually we could have ifcopenshell use FreeCAD and produce Part Shapes natively? That could be interesting...

[bernd]

... we could have ifcopenshell use FreeCAD and produce Part Shapes natively? That could be interesting...

I have no idea how this works, but that would be cool.

[bernd]

commands used for code formating in importer and importer helper:

Code: Select all

flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFC.py
flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFCHelper.py

[bernd]

I did very small code formating on export modules:

Code: Select all

flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265,E222  --max-line-length=150  src/Mod/Arch/exportIFC.py
flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265  --max-line-length=150  src/Mod/Arch/exportIFCHelper.py

[bernd]

Code: Select all

flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFC.py
flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFCHelper.py
flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265,E222  --max-line-length=150  src/Mod/Arch/exportIFC.py
flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265  --max-line-length=150  src/Mod/Arch/exportIFCHelper.py

Code: Select all

$
$ flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFC.py
src/Mod/Arch/importIFC.py:42:1: E266 too many leading '#' for block comment
src/Mod/Arch/importIFC.py:240:5: F401 'ifcopenshell.geom' imported but unused
src/Mod/Arch/importIFC.py:766:151: E501 line too long (151 > 150 characters)
src/Mod/Arch/importIFC.py:962:151: E501 line too long (153 > 150 characters)
$ flake8 --ignore=E226,E231,E701,E722,E741,F841,W503  --max-line-length=150  src/Mod/Arch/importIFCHelper.py
$ flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265,E222  --max-line-length=150  src/Mod/Arch/exportIFC.py
src/Mod/Arch/exportIFC.py:49:1: E266 too many leading '#' for block comment
$ flake8 --ignore=E226,E231,E701,E722,E741,F841,W503,E261,E265  --max-line-length=150  src/Mod/Arch/exportIFCHelper.py
$