AddOn manager clones master, but github switched to main

[Kunda1]

Someone has to update the github submodules from AddOn manager repo.

I can do this. But it will not happen before Sunday evenning Zürich time zone.

What needs to be done specifically?

[bernd]

Someone has to update the github submodules from AddOn manager repo.

I can do this. But it will not happen before Sunday evenning Zürich time zone.

What needs to be done specifically?

normally a

Code: Select all

git submodule update --init --recursive trails

does the trick, but because of restructure a commit of trails submodule pivy-trackers was missing, which means it had to be done manually. See https://github.com/FreeCAD/FreeCAD-addo ... 7204590ea6

[bernd]

BTW: it is master: git commit 475668638a81 The AddOn manager started to clone the default branch and not any longer the master branch.

[HakanSeven12]

Is that mean normal users can install trails without using a git code?

[bernd]

Is that mean normal users can install trails without using a git code?

no, because the AddOn manage still does not support submodules AFAIK. But if they try at least the correct branch (in case of trails dev) will be cloned. Just give it a try ... temprary move your trails folder out of Mod and get trails with the AddOn manager.

[Kunda1]

Can anyone check if Extension Manager (the add-on manager's replacement) supports submodules? (I'm on mobile atm and can't easily check)

[bernd]

BTW: it is master: git commit 475668638a81 The AddOn manager started to clone the default branch and not any longer the master branch.

it only works if the Python git module is available. On standard FreeCAD windows LP version Python git is not available. Thus the AddOn manager still trys to download master branch.

[kisolre]

I use locally compiled LP build and tried to install a workbench from Gitlab by adding it as custom repository. It had a Main branch but installed just fine. I have separate Git installed but cant confirm if FreeCAD used it now.

[yorik]

The problem is here: https://github.com/FreeCAD/FreeCAD/blob ... es.py#L251
When gitpython is not used, the above function is used to retrieve the location of the zip file. The question is, how to know the correct url?

[bernd]

The problem is here: https://github.com/FreeCAD/FreeCAD/blob ... es.py#L251
When gitpython is not used, the above function is used to retrieve the location of the zip file. The question is, how to know the correct url?

If gitlab is used the question reduces to what is the default branch AFAIK, thus https://davidwalsh.name/get-default-branch-name

as an example trails wb which uses dev as default branch

Code: Select all

$ git ls-remote --symref https://github.com/joelgraff/freecad.trails HEAD | awk -F'[/\t]' 'NR == 1 {print $3}'
dev