Helping to review pull requests

[yorik]

and please add spanner888 on github

Done!

[markus23]

Please add also me: markus2330

Thank you

[vanuan]

GitHub username: vanuan

Experienced programmer having some spare time due to pandemic.

[TheMarkster]

pinged by pinger macro

Add me github user mwganson

[marioalexis]

Hi
user marioalexis84

[freman]

Not making any promises but I can see this may help speed up PRs getting processed.
J-Dunn on github.

I assume that members of this new group will not actually be able to merge, just post a +ve or -ve review: a bit like peer review for PRs. Sounds like a good idea. I hope it works better than peer review !

[ezzieyguywuf]

I'd like to read-through PR's and provide comments, though I don't currently have a dev environment set up to compile FreeCAD.

Would that be helpful? If so, please add ezzieyguywuf on github.

edit: NVM, it seems I can already do reviews for some reason.

See PR 3804 for an example of the type of help/reviews I can provide.

Please let me know if this is helpful, or if it is more preferable to compile/test the code (which I cannot conveniently do at the moment).

edit2: is it possible to add some more tags to the PR's? i.e. something like "partially reviewed" and "fully reviewed"?

I found the "On Hold" tag very helpful when skimming through, trying to find things to review. Other than that, though, I have no indication of whether or not any particular PR needs a review. I can take a guess based on the number of comments, but I doubt that's a very effective way to determine where reviews are needed.

[chrisb]

Would that be helpful?

As an experienced FreeCAD programmer it would be great if you could have a look at realthunder's pending fixes for the Expression engine. That PR seems to be one of the showstoppers for a 0.19 stable.

[ezzieyguywuf]

As an experienced FreeCAD programmer it would be great if you could have a look at realthunder's pending fixes for the Expression engine. That PR seems to be one of the showstoppers for a 0.19 stable.

I’ve been skipping realthunder’s PRs due to them being so huge and daunting.

As you’ve pointed out this specific PR though, I’ll definitely look at this one next

[chrisb]

As you’ve pointed out this specific PR though, I’ll definitely look at this one next

Thank you!