Defeaturing

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
freecad-heini-1
Posts: 7301
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Defeaturing

Post by freecad-heini-1 » Thu Jul 05, 2018 10:36 am

easyw-fc wrote:
Wed Jul 04, 2018 10:54 am
Chris_G wrote:
Tue Jul 03, 2018 8:36 pm
it seems that Cmake doesn't find OCC.
Contrary to what is written in my previous notes, it seems that I did install OCC
thx! finally I got it built!
Just a great addition and as easy as just selecting the faces to be defeatured!
Fillet and Chamfer easy to go away too :D
Looking forward to see it in the main branch :D
sgrogan wrote:
Mon Jul 02, 2018 9:48 pm
.. ping
PS @sgrogan do you think it would be possible to have a Windows daily build with OCC 7.3?
PPS my defeaturing tools will be still useful for stable and legacy FC builds ;)
+1
And please a Ubuntu version.
User avatar
Chris_G
Posts: 1477
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Defeaturing

Post by Chris_G » Thu Jul 05, 2018 1:19 pm

i made a PR this morning.
But I don't know if it will be merged.
There is probably some mistakes in it, since the AppVeyor and Travis-CI builds failed.
User avatar
easyw-fc
Posts: 2905
Joined: Thu Jul 09, 2015 9:34 am

Re: Defeaturing

Post by easyw-fc » Thu Jul 05, 2018 1:39 pm

Chris_G wrote:
Thu Jul 05, 2018 1:19 pm
i made a PR this morning.
But I don't know if it will be merged.
There is probably some mistakes in it, since the AppVeyor and Travis-CI builds failed.

Code: Select all

/home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/TopoShape.cpp: In member function TopoDS_Shape Part::TopoShape::defeaturing(const std::vector<TopoDS_Shape>&) const’:
/home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/TopoShape.cpp:3424:5: error: BRepAlgoAPI_Defeaturing was not declared in this scope
     BRepAlgoAPI_Defeaturing defeat;
Probably it is because some functions may have changed within OCC7.3 release...
You may consider to add an ifdef depending on OCC version.
User avatar
Chris_G
Posts: 1477
Joined: Tue Dec 31, 2013 4:10 pm
Location: France
Contact:

Re: Defeaturing

Post by Chris_G » Thu Jul 05, 2018 2:10 pm

easyw-fc wrote:
Thu Jul 05, 2018 1:39 pm
Probably it is because some functions may have changed within OCC7.3 release...
You may consider to add an ifdef depending on OCC version.
Thanks Maurice,
I think you're right, and this should fix.
User avatar
sgrogan
Posts: 6103
Joined: Wed Oct 22, 2014 5:02 pm

Re: Defeaturing

Post by sgrogan » Thu Jul 05, 2018 9:48 pm

Chris_G wrote:
Thu Jul 05, 2018 2:10 pm
I think you're right, and this should fix.
The Win 32 bit build timed out (The 64 bit version passed so I think it's not a problem)
The OSX build failed like all others, it looks like a QT related Homebrew problem.
FreeCAD actually does support default Ubuntu 14.04 libs (ie oce 0.15 = occt 6.7) I think we could make Travis use the OCCT from the PPA (currently occt 7.2)
"fight the good fight"
Post Reply

Who is online

Users browsing this forum: No registered users and 6 guests