Back port commits to 0.18 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

Good point openBrain
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Back port commits to 0.18 branch

Post by openBrain »

Kunda1 wrote: Fri Dec 20, 2019 4:24 pm Good point openBrain
Thanks. :) Not that I'm proud of these commits, but they looks to me very little risky, while with a potential high gain regarding forum threads we'll have when Inkscape 1.0 will be released and adopted. :lol:
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Back port commits to 0.18 branch

Post by Kunda1 »

Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

This one should be backported in my opinion: https://github.com/FreeCAD/FreeCAD/pull/2909
chrisb
Veteran
Posts: 53928
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.18 branch

Post by chrisb »

Is there a good reason why exactly this should be backported? Most users of Path workbench seem to use 0.19 anyway - for good reasons.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

chrisb wrote: Thu Jan 30, 2020 1:02 am Is there a good reason why exactly this should be backported? Most users of Path workbench seem to use 0.19 anyway - for good reasons.
Because our latest stable release should get all known bugfixes. Especially new users start with the stable version and not an unreleased 0.19.
chrisb
Veteran
Posts: 53928
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.18 branch

Post by chrisb »

uwestoehr wrote: Thu Jan 30, 2020 12:31 pm Because our latest stable release should get all known bugfixes.
Was there a decision made on this?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: Back port commits to 0.18 branch

Post by uwestoehr »

chrisb wrote: Thu Jan 30, 2020 10:18 pm Was there a decision made on this?
The branch maintainer has to decide, I can only make a proposal.
I don't know who the 0.18 maintainer is.
chrisb
Veteran
Posts: 53928
Joined: Tue Mar 17, 2015 9:14 am

Re: Back port commits to 0.18 branch

Post by chrisb »

No, I mean on the general strategy of having all bugfixes backported. That seems rather uncommon. New releases usually bring new features and bugfixes. Backports are made for more or less critical bugs.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Back port commits to 0.18 branch

Post by sgrogan »

uwestoehr wrote: Thu Jan 30, 2020 11:34 pm I don't know who the 0.18 maintainer is.
Its wmayer, yorik, and the WB maintainers.
Historically only critical bug fixes would be backported, like crashes!
As the FreeCAD distribution capability has increased more "usability" bugfix backports have been excepted. I would note that wmayer is the OP for this thread.

When the binaries are built/released is a loose collaboration of the packagers.

@kkremitzkii
@looo
@hobbes
@sgrogan
"fight the good fight"
Post Reply