Separate 3D Surface and Waterline (new feature) [Merged]

[roerich_64]

Now, after the applause, we have to work ...

Waterline:
To clear the 'boundbox' i switch the 'Cutt Pattern' from 'Line' to 'ZigZag.
Now it comes this error:
...

This should be fixed now, as of PR #3389. I threw in the fix with @etrombly's permission.

Thanks,
Russell

Workes great!
i'll do more real tests

bests regards
Walter

[roerich_64]

Ping...

Hi Russel.

i hope, you and all your family is be ok.

I have time now to test a little bit...

i am here:

Code: Select all

OS: Linux Mint 19.3 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21125 (Git) AppImage
Build type: Release
Branch: master
Hash: 40600a55c2fe71ff589be677f6e427ccc937d003
Python version: 3.8.2
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: German/Germany (de_DE)

A.) When i select the Face3 to clear the outside of the part, the paths goes through the part.
Warnings:

Code: Select all

Begin Waterline operation...
PathWaterline.WARNING: Defaulting cutter to standard end mill.
PathSurfaceSupport.WARNING: Face selection is unavailable for Rotational scans.  Ignoring selected faces.
PathSurfaceSupport.WARNING: PGG: No pattern set.
PathWaterline.WARNING: No path geometry generated.
PathWaterline.INFO: Waterline: All layer scans combined took 0.6953954696655273 s
PathWaterline.INFO: Operation time: 0.7502596378326416 sec.

Edit:
When i switch in the 'Property View' Cut Patterns to 'Offset' then the path goes not through the part.
With all others, it does.
When i simulate the path, it was simulated two times... ('Clear last layer' = OFF)

Stern_III_a.jpg (160.48 KiB) Viewed 1353 times

B.) There are no 'Coolant Mode' in the 'Waterline Tasks' and at the 'Property View' there is no dropdown menu to select a Coolant Mode
I can 'per hand' write 'Flood' in the 'Property View'. Then the gCode have the right commands to switch on/off the flood...

Stern_III.jpg (572.65 KiB) Viewed 1356 times

Here the file:

Test_Stern_III_A.FCStd

(179.03 KiB) Downloaded 40 times

Bests
Walter

[Russ4262]

Afternoon Walter,
My family is doing well, thank you. I hope the same for you and your family.

...
B.) There are no 'Coolant Mode' in the 'Waterline Tasks' and at the 'Property View' there is no dropdown menu to select a Coolant Mode
I can 'per hand' write 'Flood' in the 'Property View'. Then the gCode have the right commands to switch on/off the flood...
...

A PR is in the cue for this fix. Please forgive my oversight during the separation of these two operations.
Path: Waterline - Add missing `CoolantMode` input to GUI #3512

As for the paths through the model, I have not looked at that at this time.

Have a fantastic week!

Russ

[roerich_64]

Here also very well

Have a fantastic week!
...

You also

Now it is time to sleep... 01:50 in the night

Bests
Walter

[Russ4262]

Afternoon,

...
A.) When i select the Face3 to clear the outside of the part, the paths goes through the part.
...

Just wanted to let you know I believe I have found the error in the code, or rather the function/algorithm that needs to be improved. I haven't begun to fix it yet. I will try to tackle the issue in coming days as scheduling allows.

Have a nice evening,
Russ

[roerich_64]

Afternoon,

...
A.) When i select the Face3 to clear the outside of the part, the paths goes through the part.
...

Just wanted to let you know I believe I have found the error in the code, or rather the function/algorithm that needs to be improved. I haven't begun to fix it yet. I will try to tackle the issue in coming days as scheduling allows.

Have a nice evening,
Russ

Hello Russel,

Thank you for the Info.

Bests
Walter

[roerich_64]

Hi,

Update 02.06.2020 to Version 0.19_21329


OS: Linux Mint 19.3 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21280 (Git) AppImage
Build type: Release
Branch: master
Hash: 6f3160db3e88733536c7eaf97ad7d6ebd21baccd
Python version: 3.8.2
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: German/Germany (de_DE)


now i am here:

Code: Select all

OS: Linux Mint 19.3 (X-Cinnamon/cinnamon)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.21329 (Git) AppImage
Build type: Release
Branch: master
Hash: 2330eef823b32ac412d839031cc174353a76b013
Python version: 3.8.2
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: German/Germany (de_DE)

I would like to set a list with small errors here and keep this list up to date:
(if it is better to post problems with github, let me know where.)

Waterline:
open W1.) The Tasks 'Cut Pattern' have no 'Offset'. At the drop down in 'Property view' at 'Cut Pattern' there we found 'offset'.
open W2.) everything except 'offset' continues through the part.
open W3.) When i simulate the path, it was simulated two times... ('Clear last layer' = OFF)

3D-Surface:
open S1.) Task 'Cut Pattern': In english we found 'Offset'. In german there comes 'versetzen' and generated an error:
At the drop down in 'Property view' at 'Cut Pattern' there we found 'offset' also in german and all is be ok.

Code: Select all

Surfacing Select Mode
<Exception> 'Versetzen' is not part of the enumeration
Traceback (most recent call last):
  File "/tmp/.mount_FreeCAZTjOY9/usr/Mod/Path/PathScripts/PathOpGui.py", line 234, in pageGetFields
    self.getFields(self.obj)
  File "/tmp/.mount_FreeCAZTjOY9/usr/Mod/Path/PathScripts/PathSurfaceGui.py", line 71, in getFields
    obj.CutPattern = str(self.form.cutPattern.currentText())
ValueError: {'sclassname': 'N4Base10ValueErrorE', 'sErrMsg': "'Versetzen' is not part of the enumeration", 'sfile': '', 'iline': 0, 'sfunction': '', 'swhat': "'Versetzen' is not part of the enumeration", 'btranslatable': False, 'breported': True}

open S2.) at the moment 3d-surface is no longer usable ... 'avoid Last_X_Faces' have no effect when we take it at 'tasks'.
open S3.) when I use 'Avoid_last_X_Faces' in 'Property View' it comes an error:

Code: Select all

Traceback (most recent call last):
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathUtils.py", line 62, in new_function
    res = function(*args, **kwargs)
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathOp.py", line 515, in execute
    result = self.opExecute(obj)  # pylint: disable=assignment-from-no-return
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathSurface.py", line 589, in opExecute
    CMDS.extend(self._processCutAreas(JOB, obj, m, FACES[m], VOIDS[m]))
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathSurface.py", line 693, in _processCutAreas
    final.extend(self._processPlanarOp(JOB, obj, mdlIdx, COMP, 0))
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathSurface.py", line 776, in _processPlanarOp
    PGG = PathSurfaceSupport.PathGeometryGenerator(obj, cmpdShp, obj.CutPattern)
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathSurfaceSupport.py", line 99, in __init__
    self._prepareConstants()
  File "/tmp/.mount_FreeCAwJbe7w/usr/Mod/Path/PathScripts/PathSurfaceSupport.py", line 132, in _prepareConstants
    bbC = self.shape.BoundBox.Center
<class 'AttributeError'>: 'NoneType' object has no attribute 'BoundBox'
19863.2 <App> Document.cpp(3715): Failed to recompute Test_Stern_III_A#Surface: 'NoneType' object has no attribute 'BoundBox'
Recompute failed! Please check report view.

Bests
Walter

[roerich_64]

ping

push

[Russ4262]

pint

Great list and well organized! Let's fix these issues. I have started working on them.

Question:

...3D-Surface:
open S1.) Task 'Cut Pattern': In english we found 'Offset'. In german there comes 'versetzen' and generated an error:
At the drop down in 'Property view' at 'Cut Pattern' there we found 'offset' also in german and all is be ok.

Is this translation of "Offset" the only option in the list being translated to German? Are the other cut pattern options being translated to German anywhere, Tasks panel or Property View?

I will be pushing these fixes to my 3D_Surface_Waterline_Fixes branch as I complete them. This will allow users to test the fixes if so desired. I will use the same branch to submit a PR when ready.

Russ

[roerich_64]

Is this translation of "Offset" the only option in the list being translated to German? Are the other cut pattern options being translated to German anywhere, Tasks panel or Property View?

I will be pushing these fixes to my 3D_Surface_Waterline_Fixes branch as I complete them. This will allow users to test the fixes if so desired. I will use the same branch to submit a PR when ready.

Russ

Morning (4:25am)
The birds are began to singing right now..

yes, 'versetzen' is the only one. And only in the 'tasks' panel.

Walter